Skip to content

[SYCL] Implement matrix extension using new unified interface #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
steffenlarsen merged 16 commits into from
Dec 16, 2022
Merged

[SYCL] Implement matrix extension using new unified interface #7413

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
5451a62
[SYCL][INTEL] Implementation of matrix ext using new unified interface
yubingex007-a11y Nov 16, 2022
7cca50d
Merge remote-tracking branch 'intel_llvm/sycl' into matrix-unified-intel
yubingex007-a11y Nov 18, 2022
8dd77e9
address comments
yubingex007-a11y Nov 21, 2022
76cc0de
removing dynamic when defining sub_c in testcases
yubingex007-a11y Nov 21, 2022
bbf05ed
remove unnecesary from enum class use
yubingex007-a11y Nov 21, 2022
aaf2baf
move Group to the start of joint_matrix's parameter list, make get_wi…
yubingex007-a11y Dec 8, 2022
2b4c196
support joint_matrix_store for use.a and use.b
yubingex007-a11y Dec 12, 2022
6fc2fa1
Merge remote-tracking branch 'intel_llvm/sycl' into matrix-unified-intel
yubingex007-a11y Dec 12, 2022
715748c
replace sycl::ext::oneapi::experimental::bfloat16 with sycl::ext::one…
yubingex007-a11y Dec 12, 2022
3658f70
fix fail of sycl/test/matrix/query-use.cpp
yubingex007-a11y Dec 12, 2022
46ec9ad
Merge remote-tracking branch 'intel_llvm/sycl' into matrix-unified-intel
yubingex007-a11y Dec 14, 2022
2a0fd7c
fix lint's issue
yubingex007-a11y Dec 14, 2022
99c428f
fix lint's issue
yubingex007-a11y Dec 14, 2022
afd4373
move wi_data unified again
yubingex007-a11y Dec 14, 2022
19923b9
fix some smal issues
yubingex007-a11y Dec 15, 2022
b8edc68
address dounia's comments
yubingex007-a11y Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sycl/include/CL/__spirv/spirv_types.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,22 @@ enum class GroupOperation : uint32_t {
ExclusiveScan = 2
};

#if (SYCL_EXT_ONEAPI_MATRIX_VERSION > 1)
enum class MatrixLayout : uint32_t {
RowMajor = 0,
ColumnMajor = 1,
Packed = 2,
Dynamic = 3
};
#else
enum class MatrixLayout : uint32_t {
RowMajor = 0,
ColumnMajor = 1,
PackedA = 2,
PackedB = 3,
Unused = 4
Copy link
Contributor

@dkhaldi dkhaldi Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused is not needed

Copy link
Contributor

@dkhaldi dkhaldi Nov 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for use, Dmitry is removing unecessary in this patch #7335
it will be merged soon. Once it is merged, this PR should be updated as well.

Copy link
Contributor

@dkhaldi dkhaldi Nov 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yubingex007-a11y #7335 has been merged. You can rebase your patch to remove all "unnecessary" use occurrences.

};
#endif

enum class MatrixUse : uint32_t {
MatrixA = 0,
Expand Down
Loading