[NFC] Remove MatrixUse::Unnecessary #7335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was previously introduced for backwards compatibility with legacy (without Use matrix paramter) API. It is actually not needed. Signed-off-by: Sidorov, Dmitry <[email protected]>
Signed-off-by: Sidorov, Dmitry <[email protected]>
dkhaldi
reviewed
Nov 9, 2022
| template <typename T, std::size_t R, std::size_t C, | ||
| __spv::MatrixUse U = __spv::MatrixUse::Unnecessary, | ||
| template <typename T, std::size_t R, std::size_t C, __spv::MatrixUse U, | ||
| __spv::MatrixLayout L = __spv::MatrixLayout::RowMajor, |
Contributor
There was a problem hiding this comment.
we are making the change to dynamic in this PR right?
If yes, the default for layout should be dynamic
Contributor
Author
There was a problem hiding this comment.
This PR was meant by me to just remove MatrixUse::Unnecessary. Adding dynamic requires a change in layout enum guarding it with if MATRIX_VERSION - and AFAIK Bing is doing this work.
dkhaldi
reviewed
Nov 9, 2022
| SPV_MATRIX_LAYOUT_TRAITS(layout::row_major, __spv::MatrixLayout::RowMajor) | ||
| SPV_MATRIX_LAYOUT_TRAITS(layout::col_major, __spv::MatrixLayout::ColumnMajor) | ||
| SPV_MATRIX_LAYOUT_TRAITS(layout::packed_a, __spv::MatrixLayout::PackedA) | ||
| SPV_MATRIX_LAYOUT_TRAITS(layout::packed_b, __spv::MatrixLayout::PackedB) |
Contributor
There was a problem hiding this comment.
when we should make the change: unused --> dynamic
packed_a and packed_b --> packed
Signed-off-by: Sidorov, Dmitry <[email protected]>
Contributor
Author
|
Manually tests on PVC, the patch works |
romanovvlad
approved these changes
Nov 14, 2022
Contributor
Author
|
@dkhaldi please take a look |
steffenlarsen
approved these changes
Nov 17, 2022
yubingex007-a11y
added a commit
to yubingex007-a11y/llvm
that referenced
this pull request
Dec 26, 2022
romanovvlad
pushed a commit
that referenced
this pull request
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was previously introduced for backwards compatibility with legacy (without Use matrix parameter) API. It is actually not needed.
Signed-off-by: Sidorov, Dmitry [email protected]