Skip to content

[SYCL] Create kernel bundle when non-native specialization constants are unset #4358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
romanovvlad merged 2 commits into from
Aug 19, 2021
Merged

[SYCL] Create kernel bundle when non-native specialization constants are unset #4358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6ed70f
[SYCL] Create kernel bundle when non-native specialization constants …
steffenlarsen Aug 17, 2021
d8e30f2
Manifest kernel bundle when storing lambda
steffenlarsen Aug 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions sycl/include/CL/sycl/handler.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -551,6 +551,13 @@ class __SYCL_EXPORT handler {
// arguments.
MArgs = std::move(MAssociatedAccesors);
}

// If the kernel lambda is callable with a kernel_handler argument, manifest
// the associated kernel handler.
if (detail::isKernelLambdaCallableWithKernelHandler<KernelType,
LambdaArgType>()) {
getOrInsertHandlerKernelBundle(/*Insert=*/true);
}
}

/// Checks whether it is possible to copy the source shape to the destination
Expand Down
13 changes: 4 additions & 9 deletions sycl/source/detail/scheduler/commands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1754,15 +1754,10 @@ pi_result ExecCGCommand::SetKernelParamsAndLaunch(
"device",
PI_INVALID_OPERATION);
}
if (DeviceImageImpl != nullptr) {
RT::PiMem SpecConstsBuffer =
DeviceImageImpl->get_spec_const_buffer_ref();
Plugin.call<PiApiKind::piextKernelSetArgMemObj>(Kernel, NextTrueIndex,
&SpecConstsBuffer);
} else {
Plugin.call<PiApiKind::piextKernelSetArgMemObj>(Kernel, NextTrueIndex,
nullptr);
}
assert(DeviceImageImpl != nullptr);
RT::PiMem SpecConstsBuffer = DeviceImageImpl->get_spec_const_buffer_ref();
Plugin.call<PiApiKind::piextKernelSetArgMemObj>(Kernel, NextTrueIndex,
&SpecConstsBuffer);
break;
}
}
Expand Down