[SYCL] Create kernel bundle when non-native specialization constants are unset #4358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are unset The kernel bundle carrying the device memory used for specialization constants on systems that do not support specialization constants natively was only initialized if a specialization constant was either written to or read from prior to kernel execution. These changes either forces the creation of a kernel bundle if the kernel has a specialization constant argument and a kernel bundle does not exist already. Signed-off-by: Steffen Larsen <[email protected]>
romanovvlad
reviewed
Aug 17, 2021
romanovvlad
reviewed
Aug 17, 2021
Signed-off-by: Steffen Larsen <[email protected]>
romanovvlad
approved these changes
Aug 18, 2021
Contributor
|
@steffenlarsen FYI, I reported this failure and created PR to disable the failing test: #4368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel bundle carrying the device memory used for specialization constants on systems that do not support specialization constants natively was only initialized if a specialization constant was either written to or read from prior to kernel execution. These changes either forces the creation of a kernel bundle if the kernel has a specialization constant argument and a kernel bundle does not exist already.