Skip to content

[SYCL][ESIMD] LowerESIMD: add 'buffer_t' MD for accessor kernel args. #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbobrovs wants to merge 2 commits into from
Closed

[SYCL][ESIMD] LowerESIMD: add 'buffer_t' MD for accessor kernel args. #2748

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d26bd3
[SYCL][ESIMD] LowerESIMD: add 'buffer_t' MD for accessor kernel argum…
kbobrovs Nov 3, 2020
ce41254
[SYCL][ESIMD] Handle absense of kernel_arg_accessor_ptr MD in LowerES…
kbobrovs Nov 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions llvm/lib/SYCLLowerIR/LowerESIMD.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1127,6 +1127,7 @@ void SYCLLowerESIMDLegacyPass::generateKernelMetadata(Module &M) {
SmallVector<Metadata *, 8> ArgTypeDescs;

auto *KernelArgTypes = F.getMetadata("kernel_arg_type");
auto *KernelArgAccPtrs = F.getMetadata("kernel_arg_accessor_ptr");
unsigned Idx = 0;

// Iterate argument list to gather argument kinds and generate argument
Expand All @@ -1139,14 +1140,29 @@ void SYCLLowerESIMDLegacyPass::generateKernelMetadata(Module &M) {

if (ArgType.find("image1d_t") != std::string::npos ||
ArgType.find("image2d_t") != std::string::npos ||
ArgType.find("image3d_t") != std::string::npos ||
ArgType.find("image1d_buffer_t") != std::string::npos) {
ArgType.find("image3d_t") != std::string::npos) {
Kind = AK_SURFACE;
ArgTypeDescs.push_back(MDString::get(Ctx, ArgType));
} else {
StringRef ArgDesc = "";
if (Arg.getType()->isPointerTy())
ArgDesc = "svmptr_t";

if (Arg.getType()->isPointerTy()) {
const auto *IsAccMD =
KernelArgAccPtrs
? cast<ConstantAsMetadata>(KernelArgAccPtrs->getOperand(Idx))
: nullptr;
unsigned IsAcc =
Copy link
Contributor

@bader bader Nov 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have a kernel_arg_accessor_ptr metadata with 0 value?

IsAccMD
? static_cast<unsigned>(cast<ConstantInt>(IsAccMD->getValue())
->getValue()
.getZExtValue())
: 0;
if (IsAcc) {
ArgDesc = "buffer_t";
Kind = AK_SURFACE;
} else
ArgDesc = "svmptr_t";
}
ArgTypeDescs.push_back(MDString::get(Ctx, ArgDesc));
}

Expand Down