[SYCL][ESIMD] LowerESIMD: add 'buffer_t' MD for accessor kernel args. #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
This was referenced Nov 9, 2020
…IMD. Signed-off-by: Konstantin S Bobrovsky <[email protected]>
bader
reviewed
Nov 11, 2020
Contributor
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
Please, add a regression test.
| KernelArgAccPtrs | ||
| ? cast<ConstantAsMetadata>(KernelArgAccPtrs->getOperand(Idx)) | ||
| : nullptr; | ||
| unsigned IsAcc = |
Contributor
There was a problem hiding this comment.
Is it possible to have a kernel_arg_accessor_ptr metadata with 0 value?
Contributor
Author
|
now part of #2746 |
jsji
pushed a commit
that referenced
this pull request
Oct 11, 2024
With the latest release of spirv-tools (1.3.296) this test now passes. Original commit: KhronosGroup/SPIRV-LLVM-Translator@a217f5e3449eaa8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LowerESIMD will now use the 'kernel_arg_accessor_ptr' to detect pointers originating from accessors (rather then svm pointers) and mark them appropriately for the BE.
The other two PRs needed for this one to work are:
The patches also require at least this Gen driver:
https://github.com/intel/compute-runtime/releases/tag/20.43.18277
Signed-off-by: Konstantin S Bobrovsky [email protected]