Skip to content
This repository was archived by the owner on Aug 7, 2025. It is now read-only.

Python wheels#113

Merged
berndgassmann merged 5 commits intomasterfrom
python_wheels
Sep 6, 2021
Merged

Python wheels#113
berndgassmann merged 5 commits intomasterfrom
python_wheels

Conversation

@berndgassmann
Copy link
Copy Markdown
Contributor

@berndgassmann berndgassmann commented Sep 3, 2021

  • Updated map to 2.5.0
  • Added python wheels build
  • Removed static linking on general python build and remove the
    additional not required module shared library
  • Remove outdated and complicated plain cmake handling from docu
  • Updated version number to 4.5.0

Description

Fixes #

Where has this been tested?

  • Platform(s): ...
  • Library version: ...

Possible Drawbacks


This change is Reviewable

* Updated map to 2.5.0
* Added python wheels build
* Removed static linking on general python build and remove the
additional not required module shared library
* Remove outdated and complicated plain cmake handling from docu
* Updated version number to 4.5.0

Change-Id: Id3b3ab58c2689e68ed4fca32981182e1665fdc51
@berndgassmann
Copy link
Copy Markdown
Contributor Author

We have to wait until the latest carla-map changes are merged and the submodule was updated to the correct commit-id

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 3, 2021

Codecov Report

Merging #113 (e494484) into master (ee0136e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files         268      268           
  Lines       34826    34826           
  Branches     6399     6399           
=======================================
  Hits        28561    28561           
  Misses        805      805           
  Partials     5460     5460           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0136e...e494484. Read the comment docs.

Change-Id: Ib9a056fcac0a1797624bc71e6d8c9330e37cc185
Copy link
Copy Markdown

@fabianoboril fabianoboril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 29 of 29 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @berndgassmann)

Copy link
Copy Markdown

@fabianoboril fabianoboril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @berndgassmann)


doc/CHANGELOG.md, line 12 at r2 (raw file):

#### :ghost: Maintenance
* Ease version number handling and folder layout
* Update map to latest v2.4.5_hotfix commit

Shouldn't we update to the commit, that is currently in review?

Copy link
Copy Markdown
Contributor Author

@berndgassmann berndgassmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @fabianoboril)


doc/CHANGELOG.md, line 12 at r2 (raw file):

Previously, fabianoboril (Fabian Oboril) wrote…

Shouldn't we update to the commit, that is currently in review?

I've created a separate PR for the 4.4.2 changelog update, so let's first merge that one. Then update this one later.

Bernd Gassmann added 3 commits September 6, 2021 18:22
Change-Id: Idc5aacfb5dd5c5bda1dc27d7ebb07eef3aaf2b27
Change-Id: I1637bca8d74043b537ea28b4f5d9156aa2400d37
Change-Id: I242edbd4694014ffda231f210dc6d195216247ad
@berndgassmann berndgassmann merged commit 2ce3bc8 into master Sep 6, 2021
@berndgassmann berndgassmann deleted the python_wheels branch September 6, 2021 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants