-
Notifications
You must be signed in to change notification settings - Fork 27
Replaced ilios-browser-defaults SASS mixin with shared class
#8961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced ilios-browser-defaults SASS mixin with shared class
#8961
Conversation
e894e95 to
83ec515
Compare
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for ilios-frontend ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jrjohnson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a mixin this name was ok and worked, but as a class I think it probably needs to be split up into reset-list and reset-paragraph (or something like that) and turned into separate classes. class="sessiondescription ilios-browser-defaults" is confusing.
I can understand wanting to rename it, but why separate classes? I mean, unless you think we need a utility class that just sets |
|
I like that name. I was only pulling them apart because I couldn't think of how to keep them together with a good name. Go for it. |
83ec515 to
7649c9e
Compare
…d it where needed
7649c9e to
03a3525
Compare
dartajax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems fine to me - not sure what to test but clicked around quite a bit and looked for anything awry - nothing found - approval granted
Refs ilios/ilios#6608
Fixes ilios/ilios#6669
After a suggestion, this has been renamed from
ilios-browser-defaultstonormalize-external-editorto better reflect its utility (resetting styles forHtmlEditorcomponent instances).