Merge pull request #8961 from michaelchadwick/6669-replace-ilios-browser-defaults-sass-mixin

Replaced `ilios-browser-defaults` SASS mixin with shared class

Author: dartajax

packages/ilios-common/addon/components/learningmaterial-manager.gjs

@@ -364,7 +364,7 @@ export default class LearningMaterialManagerComponent extends Component {
             <label>
               {{t "general.description"}}:
             </label>
-            <span class="description">
+            <span class="description normalize-external-editor">
               {{#if (and @editable this.isLinkedOnlyOnce)}}
                 <HtmlEditor @content={{this.description}} @update={{set this "description"}} />
               {{else}}
@@ -376,7 +376,7 @@ export default class LearningMaterialManagerComponent extends Component {
             </span>
           </div>
           <div class="item">
-            <div class="notes">
+            <div class="notes normalize-external-editor">
               <label>
                 {{t "general.instructionalNotes"}}:
               </label>

packages/ilios-common/addon/components/new-learningmaterial.gjs

@@ -405,7 +405,7 @@ export default class NewLearningmaterialComponent extends Component {
         <label>
           {{t "general.description"}}:
         </label>
-        <span>
+        <span class="description normalize-external-editor">
           <HtmlEditor @content={{this.description}} @update={{fn (mut this.description)}} />
         </span>
       </div>

packages/ilios-common/addon/components/session/overview.gjs

@@ -599,7 +599,7 @@ export default class SessionOverview extends Component {
                 {{/if}}
               </div>
               <hr />
-              <div class="sessiondescription" data-test-description>
+              <div class="sessiondescription normalize-external-editor" data-test-description>
                 <label>{{t "general.description"}}:</label>
                 <FadeText @text={{this.description}} as |ft|>
                   {{#if @editable}}
@@ -634,7 +634,10 @@ export default class SessionOverview extends Component {
                   {{/if}}
                 </FadeText>
               </div>
-              <div class="instructional-notes" data-test-instructional-notes>
+              <div
+                class="instructional-notes normalize-external-editor"
+                data-test-instructional-notes
+              >
                 <label>{{t "general.instructionalNotes"}}:</label>
                 <FadeText @text={{this.instructionalNotes}} as |ft|>
                   {{#if @editable}}

packages/ilios-common/app/styles/ilios-common/components/learningmaterial-manager.scss

@@ -45,11 +45,6 @@
     background-color: var(--green);
   }
 
-  .notes,
-  .description {
-    @include m.ilios-browser-defaults;
-  }
-
   .loading {
     @include m.ilios-heading-h1;
     display: block;

packages/ilios-common/app/styles/ilios-common/components/new-learningmaterial.scss

@@ -30,11 +30,6 @@
     @include m.ilios-form-buttons;
   }
 
-  .notes,
-  .description {
-    @include m.ilios-browser-defaults;
-  }
-
   input,
   textarea {
     &.error {

packages/ilios-common/app/styles/ilios-common/components/session-overview.scss

@@ -93,7 +93,6 @@
 
   .sessiondescription,
   .instructional-notes {
-    @include m.ilios-browser-defaults;
     grid-column: 1 / -1;
   }
 

packages/ilios-common/app/styles/ilios-common/mixins/ilios-list.scss

@@ -64,36 +64,6 @@
   }
 }
 
-@mixin ilios-browser-defaults {
-  ul {
-    list-style-position: inside;
-    list-style-type: disc;
-  }
-
-  ol {
-    list-style-position: inside;
-    list-style-type: decimal;
-  }
-
-  ul ul,
-  ol ul {
-    list-style-position: inside;
-    list-style-type: circle;
-    margin-left: 15px;
-  }
-
-  ol ol,
-  ul ol {
-    list-style-position: inside;
-    list-style-type: lower-latin;
-    margin-left: 15px;
-  }
-
-  p {
-    margin: 0;
-  }
-}
-
 @mixin ilios-selectable-list {
   @include ilios-list-reset;
 

packages/ilios-common/app/styles/ilios-common/shared.scss

@@ -4,6 +4,7 @@
 @forward "shared/loading-shimmer";
 @forward "shared/loading-text";
 @forward "shared/main-section";
+@forward "shared/normalize-external-editor";
 @forward "shared/text-wrap";
 @forward "shared/user-search";
 @forward "shared/visually-hidden";

packages/ilios-common/app/styles/ilios-common/shared/normalize-external-editor.scss

@@ -0,0 +1,29 @@
+.normalize-external-editor {
+  ul {
+    list-style-position: inside;
+    list-style-type: disc;
+  }
+
+  ol {
+    list-style-position: inside;
+    list-style-type: decimal;
+  }
+
+  ul ul,
+  ol ul {
+    list-style-position: inside;
+    list-style-type: circle;
+    margin-left: 15px;
+  }
+
+  ol ol,
+  ul ol {
+    list-style-position: inside;
+    list-style-type: lower-latin;
+    margin-left: 15px;
+  }
+
+  p {
+    margin: 0;
+  }
+}