Skip to content

refactor: remove network as default plugin #4586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julienrbrt merged 8 commits into from
Apr 2, 2025
Merged

refactor: remove network as default plugin #4586

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5c85a2e
chore: remove network as default plugin
Pantani Mar 19, 2025
adb622c
Merge branch 'main' into fix/default-plugins
Pantani Mar 19, 2025
e7777a8
add changelog
Pantani Mar 19, 2025
e1cfc0a
Merge branch 'main' into fix/default-plugins
Pantani Mar 20, 2025
feb620b
Merge branch 'main' into fix/default-plugins
Pantani Mar 20, 2025
f95373e
Merge remote-tracking branch 'origin/main' into fix/default-plugins
Pantani Mar 26, 2025
7639cbe
finish clean up
julienrbrt Apr 2, 2025
fddfba2
fix test
julienrbrt Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions ignite/cmd/plugin_default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,14 @@ type defaultPlugin struct {
}

const (
PluginNetworkVersion = "v0.2.2"
PluginNetworkPath = "github.com/ignite/cli-plugin-network@" + PluginNetworkVersion
PluginRelayerVersion = "hermes/v0.2.4"
PluginRelayerVersion = "hermes/v0.2.7"
PluginRelayerPath = "github.com/ignite/apps/hermes@" + PluginRelayerVersion
)

// defaultPlugins holds the plugin that are considered trustable and for which
// a command will added if the plugin is not already installed.
// When the user executes that command, the plugin is automatically installed.
var defaultPlugins = []defaultPlugin{
{
use: "network",
short: "Launch a blockchain in production",
aliases: []string{"n"},
path: PluginNetworkPath,
},
{
use: "relayer",
short: "Connect blockchains with an IBC relayer",
Expand Down
7 changes: 4 additions & 3 deletions integration/network/network_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import (
"github.com/go-git/go-git/v5/plumbing"
"github.com/stretchr/testify/require"

ignitecmd "github.com/ignite/cli/v29/ignite/cmd"
chainconfig "github.com/ignite/cli/v29/ignite/config/chain"
"github.com/ignite/cli/v29/ignite/pkg/cmdrunner/step"
"github.com/ignite/cli/v29/ignite/pkg/gomodule"
Expand All @@ -26,7 +25,9 @@ const (
spnModule = "github.com/tendermint/spn"
spnRepoURL = "https://" + spnModule
spnConfigFile = "config_2.yml"
pluginNetworkRepoURL = "https://" + ignitecmd.PluginNetworkPath
PluginNetworkVersion = "v0.2.2"
PluginNetworkPath = "github.com/ignite/cli-plugin-network@" + PluginNetworkVersion
pluginNetworkRepoURL = "https://" + PluginNetworkPath
)

// setupSPN executes the following tasks:
Expand All @@ -46,7 +47,7 @@ func setupSPN(env envtest.Env) string {
// Clone the cli-plugin-network with the expected version
err := xgit.Clone(context.Background(), pluginNetworkRepoURL, pluginPath)
require.NoError(err)
t.Logf("Checkout cli-plugin-revision to ref %q", ignitecmd.PluginNetworkPath)
t.Logf("Checkout cli-plugin-revision to ref %q", PluginNetworkPath)
// Add plugin to config
env.Must(env.Exec("add plugin network",
step.NewSteps(step.New(
Expand Down
Loading