refactor: remove network as default plugin#4586
Merged
julienrbrt merged 8 commits intomainfrom Apr 2, 2025
Merged
Conversation
Pantani
requested review from
ilgooz,
jeronimoalbi and
julienrbrt
as code owners
github-actions
bot
added
component:ci
julienrbrt
previously approved these changes
Mar 19, 2025
Member
julienrbrt
left a comment
julienrbrt
left a comment
There was a problem hiding this comment.
makes sense 👍🏾. we should add a changelog
julienrbrt
previously approved these changes
Mar 19, 2025
# Conflicts: # ignite/cmd/plugin_default.go
julienrbrt
previously approved these changes
Mar 26, 2025
Member
|
Created ignite/apps#188 as integration tests should be deleted from here. |
julienrbrt
previously approved these changes
Apr 2, 2025
julienrbrt
changed the title
julienrbrt
approved these changes
Apr 2, 2025
mergify bot
pushed a commit
that referenced
this pull request
Apr 2, 2025
* chore: remove network as default plugin * add changelog * finish clean up --------- Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 6f4aa5c) # Conflicts: # ignite/cmd/plugin_default.go # ignite/internal/tools/gen-cli-docs/main.go # integration/network/network_test.go
julienrbrt
added a commit
that referenced
this pull request
Apr 2, 2025
* refactor: remove network as default plugin (#4586) * chore: remove network as default plugin * add changelog * finish clean up --------- Co-authored-by: Julien Robert <[email protected]> (cherry picked from commit 6f4aa5c) # Conflicts: # ignite/cmd/plugin_default.go # ignite/internal/tools/gen-cli-docs/main.go # integration/network/network_test.go * fix conflicts --------- Co-authored-by: Danilo Pantani <[email protected]> Co-authored-by: Julien Robert <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.