Skip to content

Conversation

@peter279k
Copy link
Contributor

@peter279k peter279k commented Dec 30, 2021

Change log

  • Using the assertSame to make assertion equals strict.
  • Fixing the following coding style via PHP_CodeSniffer:
FILE: ...hp/systemctl-php/src/Exception/UnitTypeNotSupportedException.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 11 | ERROR | [x] Opening brace must not be followed by a blank
    |       |     line (PSR12.Classes.OpeningBraceSpace.Found)
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

@peter279k peter279k force-pushed the assertion_enhancement branch from ef83320 to 62952be Compare December 30, 2021 06:35
@icanhazstring
Copy link
Owner

icanhazstring commented Dec 30, 2021

Not required as phpunit 9 always does a strict comparison even with assertEquals. But ok

@icanhazstring icanhazstring merged commit 1d3bcd8 into icanhazstring:master Dec 30, 2021
@peter279k peter279k deleted the assertion_enhancement branch December 30, 2021 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants