Using assertSame to make assertion strict

Author: peter279k

src/Exception/UnitTypeNotSupportedException.php

@@ -9,5 +9,4 @@
  */
 class UnitTypeNotSupportedException extends \Exception
 {
-
 }

test/Integration/Command/SymfonyCommandDispatcherTest.php

@@ -22,6 +22,6 @@ public function itShouldDispatchACorrectCommand(): void
         $dispatcher->setBinary('echo');
 
         $output = $dispatcher->dispatch('a')->getOutput();
-        $this->assertEquals('a', trim($output));
+        $this->assertSame('a', trim($output));
     }
 }

test/Integration/SystemCtlTest.php

@@ -98,7 +98,7 @@ public function testCreateUnitFromSupportedSuffixShouldWord(): void
         $unit = SystemCtl::unitFromSuffix('service', 'SuccessService');
         self::assertInstanceOf(UnitInterface::class, $unit);
         self::assertInstanceOf(Service::class, $unit);
-        self::assertEquals('SuccessService', $unit->getName());
+        self::assertSame('SuccessService', $unit->getName());
     }
 
     public function testCreateUnitFromUnsupportedSuffixShouldRaiseException(): void

test/Unit/Command/SymfonyCommandTest.php

@@ -38,7 +38,7 @@ public function itShouldReturnOutputFromProcess(): void
         $process->getOutput()->willReturn('test');
 
         $command = new SymfonyCommand($process->reveal());
-        self::assertEquals('test', $command->getOutput());
+        self::assertSame('test', $command->getOutput());
     }
 
     /**
@@ -64,7 +64,7 @@ public function itShouldReturnTheCommandIfCommandRanSuccessFul(): void
         $process->isSuccessful()->willReturn(true);
 
         $command = new SymfonyCommand($process->reveal());
-        self::assertEquals($command, $command->run());
+        self::assertSame($command, $command->run());
     }
 
     /**

test/Unit/SystemCtlTest.php

@@ -70,7 +70,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnService
         $systemctl = (new SystemCtl())->setCommandDispatcher($commandDispatcherStub->reveal());
 
         $service = $systemctl->getService($unitName);
-        self::assertEquals('testService', $service->getName());
+        self::assertSame('testService', $service->getName());
     }
 
     /**
@@ -106,7 +106,7 @@ public function itShouldReturnAServiceWithTheCorrectNameOnServiceGetting(): void
         $systemctl = (new SystemCtl())->setCommandDispatcher($commandDispatcherStub->reveal());
 
         $service = $systemctl->getService($unitName);
-        self::assertEquals('testService', $service->getName());
+        self::assertSame('testService', $service->getName());
     }
 
     /**
@@ -125,7 +125,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnMountGe
 
         $mount = $systemctl->getMount($unitName);
         $this->assertInstanceOf(Mount::class, $mount);
-        $this->assertEquals($unitName, $mount->getName());
+        $this->assertSame($unitName, $mount->getName());
     }
 
     /**
@@ -161,7 +161,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnTimerGe
 
         $timer = $systemctl->getTimer($unitName);
         self::assertInstanceOf(Timer::class, $timer);
-        self::assertEquals($unitName, $timer->getName());
+        self::assertSame($unitName, $timer->getName());
     }
 
     /**
@@ -180,7 +180,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnSocketG
 
         $socket = $systemctl->getSocket($unitName);
         self::assertInstanceOf(Socket::class, $socket);
-        self::assertEquals($unitName, $socket->getName());
+        self::assertSame($unitName, $socket->getName());
     }
 
     /**
@@ -199,7 +199,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnScopeGe
 
         $scope = $systemctl->getScope($unitName);
         self::assertInstanceOf(Scope::class, $scope);
-        self::assertEquals($unitName, $scope->getName());
+        self::assertSame($unitName, $scope->getName());
     }
 
     /**
@@ -218,7 +218,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnSliceGe
 
         $slice = $systemctl->getSlice($unitName);
         $this->assertInstanceOf(Slice::class, $slice);
-        $this->assertEquals($unitName, $slice->getName());
+        $this->assertSame($unitName, $slice->getName());
     }
 
     /**
@@ -237,7 +237,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnTargetG
 
         $target = $systemctl->getTarget($unitName);
         $this->assertInstanceOf(Target::class, $target);
-        $this->assertEquals($unitName, $target->getName());
+        $this->assertSame($unitName, $target->getName());
     }
 
     /**
@@ -256,7 +256,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnSwapGet
 
         $swap = $systemctl->getSwap($unitName);
         $this->assertInstanceOf(Swap::class, $swap);
-        $this->assertEquals($unitName, $swap->getName());
+        $this->assertSame($unitName, $swap->getName());
     }
 
     /**
@@ -275,7 +275,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnAutomou
 
         $automount = $systemctl->getAutomount($unitName);
         $this->assertInstanceOf(Automount::class, $automount);
-        $this->assertEquals($unitName, $automount->getName());
+        $this->assertSame($unitName, $automount->getName());
     }
 
     /**
@@ -413,7 +413,7 @@ public function itShouldReturnATimerWithTheCorrectNameOnTimerGetting(): void
         $systemctl = (new SystemCtl())->setCommandDispatcher($commandDispatcherStub->reveal());
 
         $service = $systemctl->getService($unitName);
-        self::assertEquals('testService', $service->getName());
+        self::assertSame('testService', $service->getName());
     }
 
     /**
@@ -432,7 +432,7 @@ public function itShouldCallCommandDispatcherWithListUnitsAndUnitPrefixOnDeviceG
 
         $device = $systemctl->getDevice($unitName);
         self::assertInstanceOf(Device::class, $device);
-        self::assertEquals($unitName, $device->getName());
+        self::assertSame($unitName, $device->getName());
     }
 
     /**

test/Unit/Unit/AbstractUnitTest.php

@@ -34,7 +34,7 @@ public function itShouldReturnCorrectName(string $name): void
         $commandDispatcher = $this->prophesize(CommandDispatcherInterface::class);
         $unit = new UnitStub($name, $commandDispatcher->reveal());
 
-        self::assertEquals($name, $unit->getName());
+        self::assertSame($name, $unit->getName());
     }
 
     /**
@@ -97,7 +97,7 @@ public function itDetectsMultiInstanceUnitsCorrectly(string $name, bool $isMulti
         $commandDispatcher = $this->prophesize(CommandDispatcherInterface::class);
         $unit = new UnitStub($name, $commandDispatcher->reveal());
 
-        self::assertEquals($isMultiInstance, $unit->isMultiInstance());
+        self::assertSame($isMultiInstance, $unit->isMultiInstance());
     }
 
     /**
@@ -177,7 +177,7 @@ public function itDetectsMultiInstanceInstanceNamesCorrectly(string $name, ?stri
         $commandDispatcher = $this->prophesize(CommandDispatcherInterface::class);
         $unit = new UnitStub($name, $commandDispatcher->reveal());
 
-        self::assertEquals($instanceName, $unit->getInstanceName());
+        self::assertSame($instanceName, $unit->getInstanceName());
     }
 
     /**

test/Unit/Utils/OutputFetcherTest.php

@@ -135,7 +135,7 @@ public function itDeterminesTheCorrectAmountOfUnitsDataProvider(): array
     public function itOnlyExtractsTheUnitNames(string $output, string $suffix, array $expectedUnitNames): void
     {
         $units = OutputFetcher::fetchUnitNames($suffix, $output);
-        self::assertEquals($expectedUnitNames, $units);
+        self::assertSame($expectedUnitNames, $units);
     }
 
     /**