-
Notifications
You must be signed in to change notification settings - Fork 89
Handle new gtfs-lib response for encoded polylines #630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #630 +/- ##
===========================================
- Coverage 36.61% 15.68% -20.93%
===========================================
Files 326 326
Lines 17782 16627 -1155
Branches 5397 5025 -372
===========================================
- Hits 6510 2608 -3902
- Misses 9786 11976 +2190
- Partials 1486 2043 +557
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
binh-dam-ibigroup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address merge conflicts and build failures...
evansiroky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Fix failing travis build
- Fix merge conflicts
evansiroky
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, pending the changes in conveyal/gtfs-lib#297 percolating it's way through the pipeline.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good and seems to be working after regenerating editor snapshots.
|
Marked as blocked until datatools-server has the latest gtfs-lib release. |
|
Something I just noticed... the Feed Version map still uses the raw GTFS shapes attributes to find the shapes: datatools-ui/lib/gtfs/actions/shapes.js Lines 24 to 48 in 93a7dec
Can this be updated too? |
Checklist
devbefore they can be merged tomaster)Description
fix #627. Alternative approach to #628. This works with changes from conveyal/gtfs-lib#297