Skip to content

Conversation

@landonreed
Copy link
Contributor

@landonreed landonreed commented Nov 23, 2020

Checklist

  • Appropriate branch selected (all PRs must first be merged to dev before they can be merged to master)
  • Any modified or new methods or classes have helpful JSDoc and code is thoroughly commented
  • The description lists all applicable issues this PR seeks to resolve
  • The description lists any configuration setting(s) that differ from the default settings
  • All tests and CI builds passing

Description

Removes the editor map layer control to show routes on the map. Fixes #627. Commented out because there is client interest in this feature coming back, but at the moment it's too risky.

@codecov-io
Copy link

codecov-io commented Nov 23, 2020

Codecov Report

Merging #628 (e32b55f) into dev (725e897) will decrease coverage by 20.94%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #628       +/-   ##
===========================================
- Coverage   36.61%   15.66%   -20.95%     
===========================================
  Files         326      326               
  Lines       17786    16609     -1177     
  Branches     5400     5022      -378     
===========================================
- Hits         6512     2602     -3910     
- Misses       9787    11967     +2180     
- Partials     1487     2040      +553     
Flag Coverage Δ
end_to_end_tests ?
unit_tests 15.66% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ib/editor/components/map/EditorMapLayersControl.js 0.00% <0.00%> (-41.38%) ⬇️
...nager/components/validation/ServicePerModeChart.js 0.00% <0.00%> (-85.90%) ⬇️
lib/manager/components/validation/TripsChart.js 0.00% <0.00%> (-80.40%) ⬇️
lib/manager/components/HomeProjectDropdown.js 0.00% <0.00%> (-72.73%) ⬇️
...b/manager/containers/ActiveFeedVersionNavigator.js 0.00% <0.00%> (-70.00%) ⬇️
lib/admin/components/UserRow.js 0.00% <0.00%> (-67.40%) ⬇️
lib/editor/components/EditorSidebar.js 0.00% <0.00%> (-66.67%) ⬇️
lib/editor/containers/ActiveGtfsEditor.js 0.00% <0.00%> (-66.67%) ⬇️
lib/manager/components/version/VersionDateLabel.js 0.00% <0.00%> (-66.67%) ⬇️
lib/editor/components/EditorInput.js 0.00% <0.00%> (-65.69%) ⬇️
... and 262 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 725e897...e32b55f. Read the comment docs.

Copy link
Contributor

@evansiroky evansiroky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve this for now, but once this is merged and it closes #627, the issue should be reopened because this merely suppresses the problem instead of fixing the underlying problem. It'd probably be a good idea to encode polylines on the backend so that various calls to retrieve shape data won't require outputting raw shape data.

@evansiroky evansiroky removed their assignment Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor: Show routes on a map causes out of memory issues

5 participants