refactor(parsers): move and rename parsers to a new parser directory#696
Merged
refactor(parsers): move and rename parsers to a new parser directory#696
Conversation
zarov
reviewed
Mar 26, 2018
src/Parser/KmzParser.js
Outdated
| import Coordinates from '../Core/Geographic/Coordinates'; | ||
|
|
||
| function KMZLoader() { | ||
| function KMZParser() { |
Contributor
There was a problem hiding this comment.
If the file is KmzParser please rename it here as KmzParser too.
mbredif
force-pushed
the
parser_refacto
branch
2 times, most recently
from
e0b32b4 to
8a63a79
Compare
Multiple classes are in charge of decoding file chunks. They were scattered into multiple directories and had different names : Loaders, Parsers, IoDrivers... They are now all moved to a new src/Parser directory This commit addresses first item of #695
zarov
suggested changes
Mar 26, 2018
Contributor
zarov
left a comment
zarov
left a comment
There was a problem hiding this comment.
Not good in fact, there are still some ioDXBIL references.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Multiple classes are in charge of decoding file chunks. They were scattered into multiple directories and had different names : Loaders, Parsers, IoDrivers...
They are now all moved to a new src/Parser directory.
Motivation and Context
This commit addresses first item of #695 : "Move and rename JS files in charge of formatting into a Parser directory"