Removal of the layer count restriction by gchoqueux · Pull Request #2612 · iTowns/itowns

gchoqueux · 2025-10-09T16:36:05Z

See proposal ([proposal] Remove the restriction on the number of layers while simplifying the code. #2614 )

WARNING : There’s still unresolved bugs:

tiles disappear because of an improperly initialized bbox.
Opacity, vibility and effects haven’t been reconnected yet.

Description

Replace all textures array by just 2 textures, map and displacement map. All array textures are flatten in these maps.

Motivation and Context

removal of the layer count restriction
code simplification
first step :
- to replace LayeredMaterial with any Three.js materials
- to support any raster re-projection

Desplandis · 2025-10-10T07:21:23Z

Could you open a proposal for this PR? Describing what problem you want to resolve and explain your solution. =)

Neptilo · 2025-10-22T08:41:02Z

packages/Main/src/Renderer/LayeredMaterial.ts

+
+        rtCache.set(textureSetId, renderTarget);
+    } else {
+        drawMap(renderTarget, tiles, renderer, extent);


If we're caching the render targets, what is the use of redrawing their textures every time we access them? Am I missing something?

Yes, it's temporary. I'll add a mechanism to update the texture and parent texture when the opacity changes.

Neptilo · 2025-10-22T08:52:02Z

packages/Main/src/Renderer/LayeredMaterial.ts

+
+        drawMap(renderTarget, tiles, renderer, extent);
+
+        rtCache.set(textureSetId, renderTarget);


I was caching array render targets instead of array textures because it was impossible to extract the textures from the RTs and manage their memory separately, but maybe now that you're using simple render targets, this becomes possible and we can just maintain a cache of textures directly, and only use one RT for everything?

I'm not sure, There might be a problem with the framebuffer linked to the render target
To try

Neptilo · 2025-10-22T08:55:51Z

packages/Main/src/Renderer/WebGLComposer.ts

    renderer.setRenderTarget(previousRenderTarget);
+    renderer.setClearAlpha(a);

    return renderTarget;


The returned value is not used anymore and the documented type is now incorrect

it's draft PR, it's still evolving, no need for an in-depth review right now

Neptilo · 2025-10-22T09:26:26Z

packages/Main/src/Renderer/LayeredMaterial.ts

@@ -94,86 +94,35 @@ const rtCache = new LRUCache<string, THREE.WebGLArrayRenderTarget>({
 * @param type - Layer set identifier: 'c' for color, 'e' for elevation.
 * @param renderer - The renderer used to render textures.


To be updated

Neptilo · 2025-10-22T09:29:34Z

packages/Main/src/Renderer/ProjectionMaterials.js

+        uniform vec4 offsetScale;
+        uniform float opacity;
+
+        const float CTOYL = 20037508.34 / 3.141592653589793 * 0.69314718;


Could you comment what these numbers represent?

i'll add some comment

20037508.34 : max projection in speudo mercator

0,69... : Ln(2)

Neptilo · 2025-10-22T09:31:09Z

packages/Main/src/Renderer/ProjectionMaterials.js

+    uniforms: {
+        // This uniform will be updated with each source 2D texture
+        map: { value: null },
+        texture_footprint: { value: new THREE.Vector2() },


Could you comment what these properties represent?

Footprint means the area/extent covered by something on the ground.

map: map to project on the ground

texture_footprint : texture coverage on ground

camera_footprint : camera coverage visible on ground

offsetScale: the map portion to be projected

gchoqueux added enhancement 🚀 refactor 🏭 labels Oct 9, 2025

gchoqueux force-pushed the refacto/oneMap branch from a424058 to e963972 Compare October 10, 2025 09:23

gchoqueux mentioned this pull request Oct 10, 2025

[proposal] Remove the restriction on the number of layers while simplifying the code. #2614

Open

gchoqueux force-pushed the refacto/oneMap branch from e963972 to c2a1517 Compare October 21, 2025 16:03

Neptilo reviewed Oct 22, 2025

View reviewed changes

gchoqueux force-pushed the refacto/oneMap branch from c2a1517 to 813670b Compare October 27, 2025 09:20

gchoqueux force-pushed the refacto/oneMap branch from 813670b to 92e746a Compare November 6, 2025 10:06

gchoqueux force-pushed the refacto/oneMap branch 2 times, most recently from 743300c to e40bdb5 Compare November 19, 2025 15:18

gchoqueux force-pushed the refacto/oneMap branch 3 times, most recently from 6b4f653 to b8f2e2e Compare December 15, 2025 14:04

gchoqueux force-pushed the refacto/oneMap branch from b8f2e2e to cfeace0 Compare January 6, 2026 13:42

gchoqueux force-pushed the refacto/oneMap branch from cfeace0 to 42f3068 Compare January 19, 2026 14:42

gchoqueux added 2 commits January 30, 2026 15:05

refacto(LayeredMaterial): one color map and one displacementMap.

6a90149

refacto(TileBuilder): remove useless uv building

f81e8c3

gchoqueux force-pushed the refacto/oneMap branch from 42f3068 to f81e8c3 Compare January 30, 2026 14:07


		drawMap(renderTarget, tiles, renderer, extent);

		rtCache.set(textureSetId, renderTarget);

		@@ -94,86 +94,35 @@ const rtCache = new LRUCache<string, THREE.WebGLArrayRenderTarget>({
		* @param type - Layer set identifier: 'c' for color, 'e' for elevation.
		* @param renderer - The renderer used to render textures.

Comments

Conversation

gchoqueux commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Motivation and Context

Uh oh!

Desplandis commented Oct 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gchoqueux Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gchoqueux Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gchoqueux Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gchoqueux commented Oct 9, 2025 •

edited

Loading

Desplandis commented Oct 10, 2025 •

edited

Loading

gchoqueux Oct 22, 2025 •

edited

Loading

gchoqueux Oct 22, 2025 •

edited

Loading

gchoqueux Oct 22, 2025 •

edited

Loading