Skip to content

Test on Windows through AppVeyor, and use NPM prepublishOnly rather than prepublish #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tbroyer merged 2 commits into from
Jul 10, 2018
Merged

Test on Windows through AppVeyor, and use NPM prepublishOnly rather than prepublish #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebeb15c
test: Add continuous integration on Windows through AppVeyor
tbroyer Jul 7, 2016
e671931
chore: Use prepublishOnly npm script rather than prepublish
tbroyer Jul 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# See https://www.appveyor.com/docs/lang/nodejs-iojs
install:
- ps: Install-Product node stable
- node --version
- npm --version
- npm ci

test_script:
- npm test

build: off
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"build": "webpack -p",
"transpile": "cross-env BABEL_DISABLE_CACHE=1 babel src --out-dir lib",
"start": "cross-env NODE_ENV=development webpack-dev-server -d --inline --hot",
"prepublish": "npm run build && npm run transpile"
"prepublishOnly": "npm run build && npm run transpile"
Copy link
Contributor

@autra autra Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the commit message:

Note that in CI (Travis and AppVeyor), "npm test" will
run "npm run build", so this scenario is still "tested".

I wholeheartedly support this change, although if I'm not mistaken, the transpile part is not run. If we switch to prepublishOnly, we should either add transpile to build or to test, or maybe both btw (is there a script name for that?)

Copy link
Contributor Author

@tbroyer tbroyer Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't transpiling already done when compiling? I mean, Babel runs as part of the Webpack build; it does not output ES5 to disk, but this is mostly equivalent in all other aspects, right?

Copy link
Contributor

@autra autra Jul 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it is, you're right. Actually, I thought we needed the lib/ folder for unit tests, but actually sources are compiled on the fly by mocha apparently. I think I mixed up with the old version of integration tests, before we used puppeeter.

},
"files": [
"*.md",
Expand Down