You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Improves WP reached detection for fixed wing to remove dependency on nav_fw_loiter_radius. Detection now relies on checking bearing to WP relative to initial bearing to WP which is more reliable than checking distance based on a loiter radius that may not actually be achieved if set incorrectly.
Adds new Nav state flag NAV_CTL_HOLD to define when Nav hold states are active or will become active when WP is reached. Cleans up check for Nav Hold being active.
Replaces "Hover" with "Loiter" where relevant which seems more appropriate given planes generally can't hover.
Moves Landing Detected arm blocker reset code to fc_core.c updateArmingStatus which is the more correct location than in the landing detection code itself.
It works great.. Thanks.
I ran it through some back to back tests against the current method.. And even set nav_fw_loiter_radius to a low 5m. Which it couldn't possibly do. But it still made the safehome location each time based on the bearing, and instantly start descending to the nav_rth_home_altitude or Landing Approach altitude and loitered around.
Yes, using using relative bearing is a much better method than distance for planes that loiter around and never actually reach the waypoint itself. Need to check this with multirotor though just to be sure odd things don't happen, might be possible in the next few days.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR makes following changes:
nav_fw_loiter_radius. Detection now relies on checking bearing to WP relative to initial bearing to WP which is more reliable than checking distance based on a loiter radius that may not actually be achieved if set incorrectly.NAV_CTL_HOLDto define when Nav hold states are active or will become active when WP is reached. Cleans up check for Nav Hold being active.Landing Detectedarm blocker reset code tofc_core.c updateArmingStatuswhich is the more correct location than in the landing detection code itself.Tested OK for fixed wing on HITL.