mavlink: send RC_CHANNELS instead of RC_CHANNELS_RAW to support 18 channels #8282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@DzikuVx Can this be included in 7.1? Actually it should have been implemented with Mavlink 2 introduction into inav. |
|
Please please please release this ASAP |
|
Will this ever be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mavlink RC and mavlink protocol v2 has been implemented in INAV ✔️
Mavlink RC supports 16 channels with Mavlink v2 and 8 channels with Mavlink v1 ✔️
FC still sends back RC_CHANNELS_RAW message which supports 8 channels only ❌
This PR sends RC_CHANNELS instead of RC_CHANNELS_RAW if Mavlink v2 protocol is selected to support 18 channels and allow telemetry viewer app https://github.com/RomanLut/android-taranis-smartport-telemetry to show state of 18 channels instead of 8:
Existing functionality with Mavlink v1 is unchanged.
References:
https://mavlink.io/en/messages/common.html#RC_CHANNELS_OVERRIDE
https://mavlink.io/en/messages/common.html#RC_CHANNELS_RAW
https://mavlink.io/en/messages/common.html#RC_CHANNELS