Reversible ESC's for rovers: Don't start motor with high throttle in the mid of the stick #7714
Conversation
yajo10
changed the title
thanks for it! |
|
This issue should be related: #5820 |
src/main/flight/mixer.c
Outdated
| motorValueWhenStopped = getReversibleMotorsThrottleDeadband(); | ||
| mixerThrottleCommand = constrain(rcCommand[THROTTLE], throttleRangeMin, throttleRangeMax); | ||
|
|
||
| if(feature(FEATURE_REVERSIBLE_MOTORS) && reversibleMotorsThrottleState == MOTOR_DIRECTION_BACKWARD) { |
There was a problem hiding this comment.
If this applies only for DSHOT, then if DSHOT should be added to this condition. Code works fine for non-DSHOT protocols and making that change would break that
There was a problem hiding this comment.
Thanks a lot for your reply and feedback! I have added the check at compile and at runtime. Is that ok for your?
DzikuVx
left a comment
DzikuVx
left a comment
There was a problem hiding this comment.
One small thing and seems like we are done!
|
I don't know where I read to do the review up there. I got something wrong, sorry. |
|
I'm sorry. I requested for the review, but I don't know who the notification about this request got. Seems DzikuVx was faster :) |
…ng_speed Reversible ESC's for rovers: Don't start motor with high throttle in the mid of the stick (cherry picked from commit b0b00cd)
3 participants
Hey,
that's my very very first PR I'm creating so I'm very pleased about any hints ;)
Using reversible ESCs required a bit of workarounds. See #5767 (comment).
Reversible motors turning into one direction started from the high speed end at the center of the stick to the low speed end at the end of the throttle stick.
This PR was tested by me with HAKRC_35A ESCs.