Skip to content

Conversation

@breadoven
Copy link
Collaborator

Closes #6725.

Provides setting for system message display time when multiple messages present. Also incrementally increases message display time for messages longer than 15 characters. Will double display time for messages 30 characters long. Variable time only works when armed.

@breadoven
Copy link
Collaborator Author

Tested in flight and works as expected. With a 25 character message as the longest message being displayed a setting time of 1000ms was increased to 1666ms.

@breadoven breadoven marked this pull request as ready for review April 20, 2021 20:46
@avsaase
Copy link
Member

avsaase commented Apr 22, 2021

What is the display time of the shortest message?

@breadoven
Copy link
Collaborator Author

The display time for all messages, regardless of length, increases when one of the messages is > 15 characters. If no message is > 15 characters then display time is fixed at the setting display time (default 1000ms, same as current time). The setting has a minimum limit of 500ms. This change doesn't vary the display time per message as was suggested in the linked Issue simply because it's not easy to do given the way the message cycling is set up overall, So this is a compromise solution.

@Jetrell
Copy link

Jetrell commented Nov 12, 2021

@breadoven @DzikuVx Any chance of this being merged? Given the ever increasing number of System Messages and their length, with little time to read and comprehend what just flashed before our eyes.

@breadoven
Copy link
Collaborator Author

Didn't think there was that much interest in this given it's a compromise and maybe not much of an issue for most people anyway. Still it does work so could be merged once updated to fix the conflicts.

@DzikuVx DzikuVx added this to the 5.0 milestone Jan 10, 2022
@DzikuVx DzikuVx merged commit a528a12 into iNavFlight:master Feb 15, 2022
@breadoven breadoven deleted the abo_variable_sys_msg_cycle_time branch February 15, 2022 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

System Message display time option ?

4 participants