When editing PID profiles from CMS, change the profile immediately - #3433
Merged
Conversation
This way we make sure we're always reading and writing to the selected PID profile without having to rely on so much intermediate data (with its assocciated RAM costs). It also fixes the problem when data from a PID profile could accidentaly overwrite another. Fixes #3064
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This way we make sure we're always reading and writing to the
selected PID profile without having to rely on so much intermediate
data (with its assocciated RAM costs). It also fixes the problem
when data from a PID profile could accidentaly overwrite another.
Fixes #3064