Skip to content

[T5] Fix T5 model parallel tests #9721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LysandreJik merged 1 commit into from
Jan 21, 2021
Merged

[T5] Fix T5 model parallel tests #9721

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transformers/models/t5/modeling_t5.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,9 +934,9 @@ def forward(
encoder_extended_attention_mask = encoder_extended_attention_mask.to(hidden_states.device)
if encoder_decoder_position_bias is not None:
encoder_decoder_position_bias = encoder_decoder_position_bias.to(hidden_states.device)
if head_mask is not None:
if not (isinstance(head_mask, list) and head_mask[0] is None):
Copy link
Contributor Author

@patrickvonplaten patrickvonplaten Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After calling get_head_mask, head_mask cannot be None but only be a list of None's

head_mask = head_mask.to(hidden_states.device)
if encoder_head_mask is not None:
if not (isinstance(encoder_head_mask, list) and encoder_head_mask[0] is None):
encoder_head_mask = encoder_head_mask.to(hidden_states.device)
if output_hidden_states:
all_hidden_states = all_hidden_states + (hidden_states,)
Expand Down