Skip to content

[T5] Fix T5 model parallel tests #9721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LysandreJik merged 1 commit into from
Jan 21, 2021
Merged

[T5] Fix T5 model parallel tests #9721

LysandreJik merged 1 commit into from
Jan 21, 2021

Conversation

@patrickvonplaten
Copy link
Contributor

@patrickvonplaten patrickvonplaten commented Jan 21, 2021 •
edited
Loading

What does this PR do?

Those tests were failing previously:

FAILED tests/test_modeling_t5.py::T5ModelTest::test_model_parallel_beam_search
FAILED tests/test_modeling_t5.py::T5ModelTest::test_model_parallel_equal_results
FAILED tests/test_modeling_t5.py::T5EncoderOnlyModelTest::test_model_parallel_equal_results

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

patrickvonplaten
patrickvonplaten commented Jan 21, 2021
View reviewed changes
src/transformers/models/t5/modeling_t5.py
if encoder_decoder_position_bias is not None:
encoder_decoder_position_bias = encoder_decoder_position_bias.to(hidden_states.device)
if head_mask is not None:
if not (isinstance(head_mask, list) and head_mask[0] is None):
Copy link
Contributor Author

@patrickvonplaten patrickvonplaten Jan 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After calling get_head_mask, head_mask cannot be None but only be a list of None's

LysandreJik
LysandreJik approved these changes Jan 21, 2021
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for taking care of it @patrickvonplaten!

@LysandreJik LysandreJik merged commit ca422e3 into huggingface:master Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@patrickvonplaten @LysandreJik