Skip to content

[github CI] add a multi-gpu job for all example tests #8341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LysandreJik merged 10 commits into from
Nov 9, 2020
Merged

[github CI] add a multi-gpu job for all example tests #8341

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
32b1433
add a multi-gpu job for all example tests
stas00 Nov 5, 2020
ab42b86
run only ported tests
stas00 Nov 5, 2020
5cc7308
rename
stas00 Nov 5, 2020
28229d5
explain why env is re-activated on each step
stas00 Nov 5, 2020
b088327
Merge remote-tracking branch 'origin/master' into examples-multigpu-ci
stas00 Nov 6, 2020
1e2d201
mark all unported/checked tests with @require_torch_non_multigpu_but_…
stas00 Nov 8, 2020
0d040ac
Merge remote-tracking branch 'origin/master' into examples-multigpu-ci
stas00 Nov 8, 2020
02287ee
style
stas00 Nov 8, 2020
07f65f6
Apply suggestions from code review
stas00 Nov 9, 2020
720e146
Merge remote-tracking branch 'origin/master' into examples-multigpu-ci
stas00 Nov 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 17 additions & 5 deletions .github/workflows/self-scheduled.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ jobs:
python -c "import torch; print('Cuda available:', torch.cuda.is_available())"
python -c "import torch; print('Number of GPUs available:', torch.cuda.device_count())"

- name: Run all tests on GPU
- name: Run all tests on multi-GPU
env:
OMP_NUM_THREADS: 1
RUN_SLOW: yes
Expand All @@ -238,8 +238,20 @@ jobs:
- name: Failure short reports
if: ${{ always() }}
run: cat reports/tests_torch_multiple_gpu_failures_short.txt

- name: Run all pipeline tests on GPU

- name: Run all examples tests on multi-GPU
env:
OMP_NUM_THREADS: 1
RUN_SLOW: yes
run: |
source .env/bin/activate
python -m pytest -n 1 --dist=loadfile -s --make-reports=examples_torch_multiple_gpu examples

- name: Failure short reports
if: ${{ always() }}
run: cat reports/examples_torch_multiple_gpu_failures_short.txt

- name: Run all pipeline tests on multi-GPU
if: ${{ always() }}
env:
TF_FORCE_GPU_ALLOW_GROWTH: "true"
Expand Down Expand Up @@ -306,7 +318,7 @@ jobs:
TF_CPP_MIN_LOG_LEVEL=3 python -c "import tensorflow as tf; print('TF GPUs available:', bool(tf.config.list_physical_devices('GPU')))"
TF_CPP_MIN_LOG_LEVEL=3 python -c "import tensorflow as tf; print('Number of TF GPUs available:', len(tf.config.list_physical_devices('GPU')))"

- name: Run all tests on GPU
- name: Run all tests on multi-GPU
Copy link
Contributor

@sshleifer sshleifer Nov 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Run all tests on multi-GPU
- name: Run tests/ on multi-GPU

Copy link
Contributor Author

@stas00 stas00 Nov 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But it is RUN_SLOW=1 - so everywhere else in config it says "all tests" for this env var.

env:
OMP_NUM_THREADS: 1
RUN_SLOW: yes
Expand All @@ -318,7 +330,7 @@ jobs:
if: ${{ always() }}
run: cat reports/tests_tf_multiple_gpu_failures_short.txt

- name: Run all pipeline tests on GPU
- name: Run all pipeline tests on multi-GPU
if: ${{ always() }}
env:
TF_FORCE_GPU_ALLOW_GROWTH: "true"
Expand Down