-
Notifications
You must be signed in to change notification settings - Fork 31.7k
[github CI] add a multi-gpu job for all example tests #8341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
32b1433
ab42b86
5cc7308
28229d5
b088327
1e2d201
0d040ac
02287ee
07f65f6
720e146
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| from unittest.mock import patch | ||
|
|
||
| import run_glue_with_pabee | ||
| from transformers.testing_utils import TestCasePlus | ||
| from transformers.testing_utils import TestCasePlus, require_torch_non_multigpu_but_fix_me | ||
|
|
||
|
|
||
| logging.basicConfig(level=logging.DEBUG) | ||
|
|
@@ -20,6 +20,7 @@ def get_setup_file(): | |
|
|
||
|
|
||
| class PabeeTests(TestCasePlus): | ||
| @require_torch_non_multigpu_but_fix_me | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this breaks if multigpu? should the decorator be called
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't know, that's why it has "but_fix_me" - I just added it to all tests in examples, and now we need to go over all of them, review and either make each test work under multi-gpu or designate it as non_multi_gpu. wrt naming let's discuss it in normal comments, since once resolved these get hidden. |
||
| def test_run_glue(self): | ||
| stream_handler = logging.StreamHandler(sys.stdout) | ||
| logger.addHandler(stream_handler) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But it is RUN_SLOW=1 - so everywhere else in config it says "all tests" for this env var.