-
Notifications
You must be signed in to change notification settings - Fork 3k
BIG-bench #4125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BIG-bench #4125
Conversation
…me), some edits to logging errors
|
Now the last question: let's have the dataset under I think it would be nicer, this way you and anyone in your team can update the dataset card whevener you want without going through a github PR. You just need to join the https://huggingface.co/google page using your google email :) |
|
Hi @lhoestq, Thank you so much for the help! I really appreciate it!!! After some discussion with the other bigbench organizers, I think there is a slight preference for bigbench to not be under google/bigbench since this is a collaboration with researchers from many different institutions/organizations beyond Google. I see the drawback with the updates to the dataset card having to go through a PR, but hopefully that won't be very frequent. We're finalizing putting the bigbench api on pip, so once that's finalized I just need to update the setup.py with the correct dependency and I think we are ready to merge. |
|
Ok perfect, thank you ! |
|
I noticed that in the latest windows CI run it takes forever to install the dependencies, was there any change in the bigbench dependencies recently ? |
|
oh, sorry! I just did a double check on the dependencies, and it seems like there is at least one left that should have been removed. There's also one new one added. |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks for fixing the deps :) I think this is ready to merge
|
It looks like there is a circular dependency in >>> import bigbench.api.util as bb_utils
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/circleci/.pyenv/versions/3.6.15/lib/python3.6/site-packages/bigbench/api/util.py", line 29, in <module>
import bigbench.models.query_logging_model as query_logging_model
File "/home/circleci/.pyenv/versions/3.6.15/lib/python3.6/site-packages/bigbench/models/query_logging_model.py", line 23, in <module>
import bigbench.api.util as util
AttributeError: module 'bigbench.api' has no attribute 'util' |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks for fixing it ! Let me know if there is something else to do before we merge.
In particular, let me know if you plan to make a release on PyPI so that users can use this version instead of the one hosted on GCS. For now we can merge using the GCS url, but just be careful and don't update it if possible ^^
|
Hi @lhoestq , I have one minor question that I haven't been able to figure out: Regarding pypi, we are working on a release there, but I'm told there is some issue that there is a problem regarding the upload, and we are not sure when it will be resolved, and it's not in my control. |
|
Cool ! Merging then :D
This is a bug, I opened an issue here. It should be easy to fix :) |
|
The bigbench page is available here ! https://huggingface.co/datasets/bigbench I think we can update the dataset viewer to install bigbench on it, but since this is production code I'd rather use the version on pypi for bigbench when it comes out |
This PR adds all BIG-bench json tasks to huggingface/datasets.