Extend support for streaming datasets that use pathlib.Path.glob #2876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I am thinking that ideally we should call |
This was referenced Sep 8, 2021
lhoestq
approved these changes
Sep 9, 2021
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Awesome ! Good idea to add a mock filesystem for the tests :)
Should we add rglob as well ?
Comment on lines
198
to
200
| fs, fs_token, globbed_paths = fsspec.get_fs_token_paths(xjoin(posix_path, pattern)) | ||
| if "*" not in pattern: | ||
| globbed_paths = fs.glob(globbed_paths[0]) |
Member
There was a problem hiding this comment.
I added a comment to mention that get_fs_token_paths does pattern matching only if there's a * in the pattern. Otherwise it could be unclear why you would need to glob when there's no * in the pattern.
Member
Author
There was a problem hiding this comment.
I have finally refactored this, so that it always calls fs.glob because:
get_fs_token_pathsdoes pattern matching only if there is a*- The
*inget_fs_token_pathsonly matches file names, not directory names get_fs_token_pathsdoesn't do pattern matching if there is**
Member
Author
|
Thanks, @lhoestq: the idea of adding the mock filesystem is to avoid network calls and reduce testing time ;) I have added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the support in streaming mode for datasets that use
pathlib, by patching the methodpathlib.Path.glob.Related to #2874, #2866.
CC: @severo