-
Notifications
You must be signed in to change notification settings - Fork 3k
Support streaming datasets that use pathlib #2874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is very nice ! It should fix a lot of dataset in streaming mode :)
I added a few suggestions, mostly about the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thank you !
|
I've tried #2866 again, and I get the same error. import datasets as ds
ds.load_dataset('counter', split="train", streaming=False) |
|
No worry and no stress, I just wanted to check for that case :) I'm very happy that you're working on issues I'm interested in! |
This PR extends the support in streaming mode for datasets that use
pathlib.Path.Related to: #2866.
CC: @severo