Support streaming datasets that use pathlib#2874
Merged
lhoestq merged 12 commits intohuggingface:masterfrom Sep 7, 2021
Merged
Support streaming datasets that use pathlib#2874lhoestq merged 12 commits intohuggingface:masterfrom
lhoestq merged 12 commits intohuggingface:masterfrom
Conversation
lhoestq
reviewed
Sep 7, 2021
Member
lhoestq
left a comment
There was a problem hiding this comment.
Thanks, this is very nice ! It should fix a lot of dataset in streaming mode :)
I added a few suggestions, mostly about the tests
Collaborator
|
I've tried #2866 again, and I get the same error. import datasets as ds
ds.load_dataset('counter', split="train", streaming=False) |
Member
Author
Collaborator
|
No worry and no stress, I just wanted to check for that case :) I'm very happy that you're working on issues I'm interested in! |
This was referenced Sep 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the support in streaming mode for datasets that use
pathlib.Path.Related to: #2866.
CC: @severo