Skip to content

Fix extraction protocol inference from urls with params #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhoestq merged 3 commits into from
Aug 30, 2021
Merged

Fix extraction protocol inference from urls with params #2843

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e07abf1
fix extraction protocol inference from urls with params
lhoestq Aug 27, 2021
cb6c0bd
severo's comment
lhoestq Aug 27, 2021
6542402
Update streaming_download_manager.py
lhoestq Aug 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/datasets/utils/streaming_download_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,11 @@ def _extract(self, urlpath: str) -> str:
return f"{protocol}://::{urlpath}"

def _get_extraction_protocol(self, urlpath: str) -> Optional[str]:
# get inner file: zip://train-00000.json.gz::https://foo.bar/data.zip -> zip://data/train-00000.json.gz
path = urlpath.split("::")[0]
# remove query params: https://foo.bar/train.json.gz?dl=1 -> https://foo.bar/train.json.gz
path = path.split("?")[0]
# Get extension: https://foo.bar/train.json.gz -> gz
extension = path.split(".")[-1]
if extension in BASE_KNOWN_EXTENSIONS:
return None
Expand Down