Skip to content

Fix extraction protocol inference from urls with params #2843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhoestq merged 3 commits into from
Aug 30, 2021
Merged

Fix extraction protocol inference from urls with params #2843

lhoestq merged 3 commits into from
Aug 30, 2021

Conversation

@lhoestq
Copy link
Member

@lhoestq lhoestq commented Aug 27, 2021 •
edited
Loading

Previously it was unable to infer the compression protocol for files at URLs like

https://foo.bar/train.json.gz?dl=1

because of the query parameters.

I fixed that, this should allow 10+ datasets to work in streaming mode:

  "discovery",
  "emotion",
  "grail_qa",
  "guardian_authorship",
  "pragmeval",
  "simple_questions_v2",
  "versae/adobo",
  "w-nicole/childes_data",
  "w-nicole/childes_data_no_tags_",
  "w-nicole/childes_data_with_tags",
  "w-nicole/childes_data_with_tags_"

cc @severo

severo
severo reviewed Aug 27, 2021
View reviewed changes
severo
severo reviewed Aug 30, 2021
View reviewed changes
@lhoestq lhoestq merged commit 6f7bca7 into master Aug 30, 2021
@lhoestq lhoestq deleted the fix-extraction-protocol-inference-for-urls-with-params branch August 30, 2021 13:12
@lhoestq
Copy link
Member Author

lhoestq commented Aug 30, 2021

merging since the windows error is just a CircleCI issue

severo added a commit to huggingface/dataset-viewer that referenced this pull request Aug 30, 2021
@severo
feat: 🎸 upgrade datasets to increase streaming support
ddcaa79 
Principally: huggingface/datasets#2843
@severo
Copy link
Collaborator

severo commented Aug 30, 2021

It works, eg https://observablehq.com/@huggingface/datasets-preview-backend-client#{%22datasetId%22%3A%22discovery%22} and https://datasets-preview.huggingface.tech/rows?dataset=discovery&config=discovery&split=train

@lhoestq
Copy link
Member Author

lhoestq commented Aug 30, 2021

Nice !

severo added a commit that referenced this pull request Aug 31, 2021
@severo
fix: 🐛 remove URL's query string only if it's ?dl=1
595efc7 
A lot of URL use the query strings, for example
http://opus.nlpl.eu/download.php?f=Bianet/v1/moses/en-ku.txt.zip, we
must not remove it when trying to detect the protocol. We thus remove it
only in the case of the query string being ?dl=1 which occurs on dropbox
and dl.orangedox.com. Also: add unit tests.

See #2843 for the original
discussion.
@severo severo mentioned this pull request Aug 31, 2021
Merged
lhoestq pushed a commit that referenced this pull request Aug 31, 2021
@severo
fix: 🐛 remove URL's query string only if it's ?dl=1 (#2856)
a3ee723 
A lot of URL use the query strings, for example
http://opus.nlpl.eu/download.php?f=Bianet/v1/moses/en-ku.txt.zip, we
must not remove it when trying to detect the protocol. We thus remove it
only in the case of the query string being ?dl=1 which occurs on dropbox
and dl.orangedox.com. Also: add unit tests.

See #2843 for the original
discussion.
@severo severo mentioned this pull request Feb 3, 2022
Closed
mattstern31 added a commit to mattstern31/datasets-server-storage-admin that referenced this pull request Nov 11, 2023
@mattstern31
feat: 🎸 upgrade datasets to increase streaming support
7f0e4c1 
Principally: huggingface/datasets#2843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@severo severo severo left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lhoestq @severo