Skip to content

Add support for fast tokenizer in BertScore #2770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertvillanova merged 2 commits into from
Aug 9, 2021
Merged

Add support for fast tokenizer in BertScore #2770

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e11e77e
Support fast tokenizer in BertScore
mariosasko Aug 7, 2021
f9544cf
Mention new arg in _KWARGS_DESCRIPTION
mariosasko Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions metrics/bertscore/bertscore.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,11 @@
# limitations under the License.
""" BERTScore metric. """

import functools
from contextlib import contextmanager

import bert_score
from packaging import version

import datasets

Expand Down Expand Up @@ -77,6 +79,7 @@ def filter_log(record):
specified when `rescale_with_baseline` is True.
rescale_with_baseline (bool): Rescale bertscore with pre-computed baseline.
baseline_path (str): Customized baseline file.
use_fast_tokenizer (bool): `use_fast` parameter passed to HF tokenizer. New in version 0.3.10.

Returns:
precision: Precision.
Expand Down Expand Up @@ -131,15 +134,28 @@ def _compute(
all_layers=False,
rescale_with_baseline=False,
baseline_path=None,
use_fast_tokenizer=False,
):
get_hash = bert_score.utils.get_hash
scorer = bert_score.BERTScorer

if version.parse(bert_score.__version__) >= version.parse("0.3.10"):
get_hash = functools.partial(get_hash, use_fast_tokenizer=use_fast_tokenizer)
scorer = functools.partial(scorer, use_fast_tokenizer=use_fast_tokenizer)
elif use_fast_tokenizer:
raise ImportWarning(
"To use a fast tokenizer, the module `bert-score>=0.3.10` is required, and the current version of `bert-score` doesn't match this condition.\n"
'You can install it with `pip install "bert-score>=0.3.10"`.'
)

if model_type is None:
assert lang is not None, "either lang or model_type should be specified"
model_type = bert_score.utils.lang2model[lang.lower()]

if num_layers is None:
num_layers = bert_score.utils.model2layers[model_type]

hashcode = bert_score.utils.get_hash(
hashcode = get_hash(
model=model_type,
num_layers=num_layers,
idf=idf,
Expand All @@ -149,7 +165,7 @@ def _compute(

with filter_logging_context():
if not hasattr(self, "cached_bertscorer") or self.cached_bertscorer.hash != hashcode:
self.cached_bertscorer = bert_score.BERTScorer(
self.cached_bertscorer = scorer(
model_type=model_type,
num_layers=num_layers,
batch_size=batch_size,
Expand Down