Add support for fast tokenizer in BertScore #2770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvillanova
requested changes
Aug 9, 2021
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Thanks for the fix! :)
May I ask you to update the _KWARGS_DESCRIPTION documentation with the new parameter use_fast_tokenizer?
It may also be useful to indicate that this parameter is new with a message like: "New in version 0.3.10."
albertvillanova
approved these changes
Aug 9, 2021
Member
albertvillanova
left a comment
albertvillanova
left a comment
There was a problem hiding this comment.
Thank you, @mariosasko!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a fast tokenizer in BertScore, which has been added recently to the lib.
Fixes #2765