Skip to content

Fix logging levels #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
albertvillanova merged 7 commits into from
Jun 25, 2021
Merged

Fix logging levels #2544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
46a813b
Switch some log info to debug
albertvillanova Jun 24, 2021
e692e32
Switch some log warning to info
albertvillanova Jun 24, 2021
cbcfbc0
Fix test
albertvillanova Jun 24, 2021
55c87ad
Fix test
albertvillanova Jun 24, 2021
ffa8337
Revert "Switch some log warning to info"
albertvillanova Jun 25, 2021
afcd087
Revert unnecessary test fix
albertvillanova Jun 25, 2021
f47a45a
Fix style
albertvillanova Jun 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/datasets/arrow_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1320,7 +1320,7 @@ def set_format(
self._format_kwargs = format_kwargs
self._format_columns = columns
self._output_all_columns = output_all_columns
logger.info(
logger.debug(
"Set __getitem__(key) output type to %s for %s columns "
" (when key is int or slice) and %s output other (un-formatted) columns.",
"python objects" if type is None else type,
Expand Down
2 changes: 1 addition & 1 deletion src/datasets/arrow_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,7 @@ def finalize(self, close_stream=True):
self.pa_writer.close()
if close_stream:
self.stream.close()
logger.info(
logger.debug(
"Done writing %s %s in %s bytes %s.",
self._num_examples,
self.unit,
Expand Down
2 changes: 1 addition & 1 deletion src/datasets/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,7 @@ def as_dataset(
% (self.name, self._cache_dir_root)
)

logger.info(
logger.debug(
"Constructing Dataset for split %s, from %s", split or ", ".join(self.info.splits), self._cache_dir
)

Expand Down
2 changes: 1 addition & 1 deletion src/datasets/load.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def get_imports(file_path: str):
with open(file_path, mode="r", encoding="utf-8") as f:
lines.extend(f.readlines())

logger.info("Checking %s for additional imports.", file_path)
logger.debug("Checking %s for additional imports.", file_path)
imports: List[Tuple[str, str, str, Optional[str]]] = []
is_in_docstring = False
for line in lines:
Expand Down
4 changes: 2 additions & 2 deletions src/datasets/utils/filelock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ def acquire(self, timeout=None, poll_intervall=0.05):
self._acquire()

if self.is_locked:
logger().info("Lock %s acquired on %s", lock_id, lock_filename)
logger().debug("Lock %s acquired on %s", lock_id, lock_filename)
break
elif timeout >= 0 and time.time() - start_time > timeout:
logger().debug("Timeout on acquiring lock %s on %s", lock_id, lock_filename)
Expand Down Expand Up @@ -315,7 +315,7 @@ def release(self, force=False):
logger().debug("Attempting to release lock %s on %s", lock_id, lock_filename)
self._release()
self._lock_counter = 0
logger().info("Lock %s released on %s", lock_id, lock_filename)
logger().debug("Lock %s released on %s", lock_id, lock_filename)

return None

Expand Down