Fix logging levels #2544
Merged
Fix logging levels #2544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhoestq
reviewed
Jun 24, 2021
Member
lhoestq
left a comment
lhoestq
left a comment
There was a problem hiding this comment.
Thanks for making things less verbose :)
I just have one comment about the "Reusing dataset" log, that should stay a warning IMO:
stas00
approved these changes
Jun 24, 2021
Contributor
stas00
left a comment
stas00
left a comment
There was a problem hiding this comment.
Awesome! Thank you for this adjustment, @albertvillanova!
This reverts commit e692e32.
JayantGoel001
added a commit
to JayantGoel001/datasets-1
that referenced
this pull request
Jun 25, 2021
Fix logging levels (huggingface#2544)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes default
datasetslogging can be too verbose. One approach could be reducing some logging levels, from info to debug, or from warning to info.Close #2543.
cc: @stas00