Skip to content

Update version in xor_tydi_qa.py #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lhoestq merged 2 commits into from
Jun 14, 2021
Merged

Update version in xor_tydi_qa.py #2455

lhoestq merged 2 commits into from
Jun 14, 2021

Conversation

@changjonathanc
Copy link
Contributor

@changjonathanc changjonathanc commented Jun 8, 2021

Fix #2449

@lhoestq Should I revert to the old dummy/1.0.0 or delete it and keep only dummy/1.1.0?

@albertvillanova albertvillanova marked this pull request as draft June 8, 2021 09:32
@albertvillanova albertvillanova changed the title (Draft) Update version in xor_tydi_qa.py Update version in xor_tydi_qa.py Jun 8, 2021
@lhoestq
Copy link
Member

lhoestq commented Jun 14, 2021

Hi ! Thanks for updating the version

Should I revert to the old dummy/1.0.0 or delete it and keep only dummy/1.1.0?

Feel free to delete the old dummy data files

@changjonathanc changjonathanc marked this pull request as ready for review June 14, 2021 14:27
lhoestq
lhoestq approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@lhoestq lhoestq merged commit 9a4f28a into huggingface:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhoestq lhoestq lhoestq approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@changjonathanc @lhoestq