-
Notifications
You must be signed in to change notification settings - Fork 3k
Update xor_tydi_qa url to v1.1
#2449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just noticed while I tired clearing the cache Anyone know how to fix this? Thanks. |
|
It seems like the error is not on your end. By default, the lib tries to download the version of the dataset script that matches the version of the lib, and that version of the script is, in your case, broken because the old URL no longer works. Once this PR gets merged, you can wait for the new release or set |
|
@mariosasko Thanks! It works now. Pasting the docstring here for reference. Branch name didn't work, but commit sha works. |
lhoestq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating the urls and updating the dataset_infos.json with the new checksum files :)
|
Regarding the issue you mentioned about the |
|
@lhoestq I realized I forgot to change this: datasets/datasets/xor_tydi_qa/xor_tydi_qa.py Lines 72 to 73 in fdbf5a9
What should I do? |
|
Oh indeed. Please open a PR to change this. This should be 1.1.0 |
The dataset is updated and the old url no longer works. So I updated it.
I faced a bug while trying to fix this. Documenting the solution here. Maybe we can add it to the doc (
CONTRIBUTING.mdandADD_NEW_DATASET.md).