Skip to content

Conversation

@lewtun
Copy link
Member

@lewtun lewtun commented May 31, 2021

Following the discussion with @thomwolf in #2255, this PR renames the QA template to distinguish extractive vs abstractive QA. The abstractive template will be added in a future PR.

@lewtun lewtun requested review from SBrandeis and lhoestq May 31, 2021 10:04
Copy link
Member

@lhoestq lhoestq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like having "extractive" in the name to make things explicit. However this creates an inconsistency with transformers.

See
https://huggingface.co/transformers/task_summary.html#extractive-question-answering

But this is minor IMO and I'm ok with this renaming

@lewtun
Copy link
Member Author

lewtun commented May 31, 2021

I like having "extractive" in the name to make things explicit. However this creates an inconsistency with transformers.

See
https://huggingface.co/transformers/task_summary.html#extractive-question-answering

But this is minor IMO and I'm ok with this renaming

yes i chose this convention because it allows us to match the QuestionAnsweringXxx naming and i think it's better to have task_name-subtask_name should auto-complete ever become part of the Hub :)

@lewtun lewtun merged commit 5cc895a into huggingface:master May 31, 2021
@lewtun lewtun deleted the refactor-qa-template branch May 31, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants