Skip to content

Conversation

@pspeter3
Copy link
Contributor

@pspeter3 pspeter3 commented May 7, 2025

Pass the extension map through the generation methods.

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Pass the extension map through the generation methods.
@yusukebe yusukebe changed the title Fix SSG Extension Map fix(ssg): Fix SSG Extension Map May 8, 2025
@codecov
Copy link

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.34%. Comparing base (ebc7e4b) to head (343c0bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4130   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files         168      168           
  Lines       10700    10702    +2     
  Branches     3148     3062   -86     
=======================================
+ Hits         9774     9776    +2     
  Misses        925      925           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

yusukebe commented May 9, 2025

@pspeter3 Looks good! I'll merge and release a new version soon. Thank you so much!

@yusukebe yusukebe merged commit 9381d5f into honojs:main May 9, 2025
16 checks passed
@pspeter3 pspeter3 deleted the fix-ssg-extension-map branch May 9, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants