Skip to content

fix(ssg): Fix SSG Extension Map #4130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025
Merged

fix(ssg): Fix SSG Extension Map #4130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09ce222
Fix SSG Extension Map
pspeter3 May 7, 2025
11c77d0
Update tests based on feedback
pspeter3 May 9, 2025
343c0bc
Fix content type
pspeter3 May 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion src/helper/ssg/ssg.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,18 @@ describe('toSSG function', () => {
})

it('Should correctly generate files with the expected paths', async () => {
await toSSG(app, fsMock, { dir: './static' })
app.get('/data', (c) =>
c.text(JSON.stringify({ title: 'hono' }), 200, {
'Content-Type': 'application/json',
})
)
await toSSG(app, fsMock, {
dir: './static',
extensionMap: {
...defaultExtensionMap,
'application/json': 'json',
},
})

expect(fsMock.writeFile).toHaveBeenCalledWith('static/index.html', expect.any(String))
expect(fsMock.writeFile).toHaveBeenCalledWith('static/about.html', expect.any(String))
Expand All @@ -173,6 +184,7 @@ describe('toSSG function', () => {
expect(fsMock.writeFile).toHaveBeenCalledWith('static/about.html', expect.any(String))
expect(fsMock.writeFile).toHaveBeenCalledWith('static/bravo.html', expect.any(String))
expect(fsMock.writeFile).toHaveBeenCalledWith('static/Charlie.html', expect.any(String))
expect(fsMock.writeFile).toHaveBeenCalledWith('static/data.json', expect.any(String))
})

it('should modify the request if the hook is provided', async () => {
Expand Down
4 changes: 3 additions & 1 deletion src/helper/ssg/ssg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,9 @@ export const toSSG: ToSSGInterface = async (app, fs, options) => {
return
}
for (const content of getContentGen) {
savePromises.push(saveContentToFile(content, fs, outputDir).catch((e) => e))
savePromises.push(
saveContentToFile(content, fs, outputDir, options?.extensionMap).catch((e) => e)
)
}
})
)
Expand Down
Loading