Skip to content

Conversation

@sairon
Copy link
Member

@sairon sairon commented Feb 3, 2026

SSIA. It seems we don't gain anything special from building LWS/ttyd during the image build, so just install it from APK.

Summary by CodeRabbit

  • New Features

    • Enabled nano theme support from shared directory.
  • Updates

    • Bumped version to 10.0.0.
    • Updated Alpine to 3.23.
    • Updated Home Assistant CLI to 4.46.0.
    • Simplified ttyd installation using Alpine package repository.
  • Refactor

    • Removed unnecessary build dependencies, reducing image complexity.
  • Documentation

    • Updated CHANGELOG for version 10.0.0 release.

Alpine already has ttyd 1.7.7 available, it appears we're not using any ttyd or
LWS config options that would mandate building it here.
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 3, 2026

📝 Walkthrough

Walkthrough

Version 10.0.0 release updates the Alpine base image to 3.23, Home Assistant CLI to 4.46.0, and simplifies the Dockerfile by using ttyd from the Alpine package repository instead of building from source. Service finish script messages are updated from "add-on" to "app" terminology.

Changes

Cohort / File(s) Summary
Version and Configuration Updates
ssh/CHANGELOG.md, ssh/config.yaml, ssh/build.yaml
Bumped version to 10.0.0, updated base image tags from Alpine 3.22 to 3.23-2025.12.2, and CLI version from 4.45.0 to 4.46.0. Removed LIBWEBSOCKETS_VERSION and TTYD_VERSION arguments.
Build Process Simplification
ssh/Dockerfile
Removed multi-step libwebsockets and ttyd build pipeline; now uses ttyd from Alpine packages. Eliminated related build dependencies and development tooling. Added sed command for nano theme configuration.
Service Finish Scripts
ssh/rootfs/etc/services.d/.../finish
Updated halt warning messages from "Halt add-on" to "Halt app" in both sshd and ttyd finish scripts. No functional changes to control flow.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately summarizes the three main changes: Alpine upgrade to v3.23, CLI bump to v4.46.0, and switching to ttyd from Alpine's package repository.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ssh-update-alpine-23

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants