Skip to content

ssh: Update description for additional software packages#4370

Merged
sairon merged 2 commits intohome-assistant:masterfrom
AJediIAm:patch-7
Feb 3, 2026
Merged

ssh: Update description for additional software packages#4370
sairon merged 2 commits intohome-assistant:masterfrom
AJediIAm:patch-7

Conversation

@AJediIAm
Copy link
Contributor

@AJediIAm AJediIAm commented Feb 1, 2026

Summary by CodeRabbit

  • Documentation
    • Updated description to clarify that additional Alpine packages are installed in the app container.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 1, 2026

📝 Walkthrough

Walkthrough

The translation description for the apks configuration package was updated to clarify that it refers to Alpine packages being installed in the app container, replacing the previous generic reference to "additional software packages" and "add-on container."

Changes

Cohort / File(s) Summary
Translation Update
ssh/translations/en.yaml
Updated configuration.apks.description to specify "Additional Alpine packages to install in the app container" instead of "Additional software packages to install in the add-on container."

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the description for additional software packages (specifically from generic 'software packages' to 'Alpine packages' and from 'add-on container' to 'app container').
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can merge this without causing a rebuild, so the comment I added to other PRs doesn't apply here. However, I'd completely reword the sentence for better clarity.

Also, please adjust the PR title, this way it'd not be clear from the Git history what was the description related to.

@home-assistant home-assistant bot marked this pull request as draft February 2, 2026 17:07
@home-assistant
Copy link

home-assistant bot commented Feb 2, 2026

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@sairon sairon marked this pull request as ready for review February 3, 2026 18:01
@home-assistant home-assistant bot requested a review from sairon February 3, 2026 18:01
@sairon sairon changed the title Update description for additional software packages ssh: Update description for additional software packages Feb 3, 2026
Copy link
Member

@sairon sairon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #4381 will be merged soon, let's get this in.

@sairon sairon merged commit b27324e into home-assistant:master Feb 3, 2026
6 of 7 checks passed
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@ssh/translations/en.yaml`:
- Around line 11-12: Update the description string that currently reads
"Additional Alpine packages to install in the app container." to use the Home
Assistant terminology "add-on container" instead of "app container"; locate the
YAML entry with the key "description: >-" and replace the phrase "app container"
with "add-on container" so the text reads "Additional Alpine packages to install
in the add-on container."

Comment on lines 11 to +12
description: >-
Additional software packages to install in the add-on container.
Additional Alpine packages to install in the app container.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Terminology inconsistency: "app container" should remain "add-on container".

The clarification from "software packages" to "Alpine packages" is a good improvement since apks specifically refers to Alpine Package Keeper packages.

However, changing "add-on container" to "app container" deviates from standard Home Assistant terminology. The ecosystem consistently uses "add-on" (this repository is even named addons), and users familiar with Home Assistant expect this term.

📝 Suggested fix
    description: >-
-      Additional Alpine packages to install in the app container.
+      Additional Alpine packages to install in the add-on container.
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
description: >-
Additional software packages to install in the add-on container.
Additional Alpine packages to install in the app container.
description: >-
Additional Alpine packages to install in the add-on container.
🤖 Prompt for AI Agents
In `@ssh/translations/en.yaml` around lines 11 - 12, Update the description string
that currently reads "Additional Alpine packages to install in the app
container." to use the Home Assistant terminology "add-on container" instead of
"app container"; locate the YAML entry with the key "description: >-" and
replace the phrase "app container" with "add-on container" so the text reads
"Additional Alpine packages to install in the add-on container."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants