Skip to content

Fix NullPointerException on resetThrottlesUnconditionally() #12145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2025
Merged

Fix NullPointerException on resetThrottlesUnconditionally() #12145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion web3/src/main/java/org/hiero/mirror/web3/state/MirrorNodeState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ private <V> WritableSingletonStateBase<V> withAnyRegisteredListeners(
@Nonnull final String serviceName,
@Nonnull final String stateKey,
@Nonnull final SingletonState<V> singleton) {
final var state = new FunctionWritableSingletonState<>(serviceName, stateKey, singleton, singleton::set);
final var state = new FunctionWritableSingletonState<>(serviceName, stateKey, singleton);
listeners.forEach(listener -> {
if (listener.stateTypes().contains(SINGLETON)) {
registerSingletonListener(serviceName, state, listener);
Expand Down
12 changes: 3 additions & 9 deletions web3/src/main/java/org/hiero/mirror/web3/state/core/FunctionWritableSingletonState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,32 +5,26 @@
import com.swirlds.state.spi.WritableSingletonStateBase;
import jakarta.annotation.Nonnull;
import java.util.Objects;
import java.util.function.Consumer;
import java.util.function.Supplier;

public class FunctionWritableSingletonState<S> extends WritableSingletonStateBase<S> {

private final Supplier<S> backingStoreAccessor;

private final Consumer<S> backingStoreMutator;

/**
* Creates a new instance.
*
* @param serviceName The name of the service that owns the state.
* @param stateKey The state key for this instance.
* @param backingStoreAccessor A {@link Supplier} that provides access to the value in the
* backing store.
* @param backingStoreMutator A {@link Consumer} for mutating the value in the backing store.
*/
public FunctionWritableSingletonState(
@Nonnull final String serviceName,
@Nonnull final String stateKey,
@Nonnull final Supplier<S> backingStoreAccessor,
@Nonnull final Consumer<S> backingStoreMutator) {
@Nonnull final Supplier<S> backingStoreAccessor) {
super(serviceName, stateKey);
this.backingStoreAccessor = Objects.requireNonNull(backingStoreAccessor);
this.backingStoreMutator = Objects.requireNonNull(backingStoreMutator);
}

@Override
Expand All @@ -40,11 +34,11 @@ protected S readFromDataSource() {

@Override
protected void putIntoDataSource(@Nonnull S value) {
backingStoreMutator.accept(value);
// No-op as we don't persist updates in web3.
}

@Override
protected void removeFromDataSource() {
backingStoreMutator.accept(null);
// No-op as we don't persist updates in web3.
}
}
Loading