Skip to content

Conversation

@bilyana-gospodinova
Copy link
Contributor

Description:
As a result of the last hedera-app bump to 0.65.1 in #12001 new singleton states were added:

  • FunctionReadableSingletonState
  • FunctionWritableSingletonState

For the writable one the implementation of putIntoDataSource() and removeFromDataSource() needs to be removed as this introduces a regression and we don't persist any changes in the DB anyway.

Fixes #12055

@bilyana-gospodinova bilyana-gospodinova added this to the 0.141.0 milestone Oct 6, 2025
@bilyana-gospodinova bilyana-gospodinova self-assigned this Oct 6, 2025
@bilyana-gospodinova bilyana-gospodinova requested a review from a team as a code owner October 6, 2025 12:59
@bilyana-gospodinova bilyana-gospodinova added the bug Type: Something isn't working label Oct 6, 2025
@lfdt-bot
Copy link

lfdt-bot commented Oct 6, 2025

🎉 Snyk checks have passed. No issues have been found so far.

security/snyk check is complete. No issues have been found. (View Details)

@codacy-production
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-31.45% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e8bbaa4) 36892 33604 91.09%
Head commit (236a209) 60875 (+23983) 36305 (+2701) 59.64% (-31.45%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#12145) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@bilyana-gospodinova bilyana-gospodinova changed the title Fix NullPointerException on resetThrottlesUnconditionally() Fix NullPointerException on resetThrottlesUnconditionally() Oct 6, 2025
@steven-sheehy steven-sheehy merged commit 22db93d into main Oct 6, 2025
33 of 34 checks passed
@steven-sheehy steven-sheehy deleted the 12055-fix-npe-on-resetThrottlesUnconditionally branch October 6, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Type: Something isn't working regression web3 Area: Web3 API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NullPointerException on ThrottleServiceManager.resetThrottlesUnconditionally()

5 participants