Skip to content

Fix ChromeHeadlessShell launch crash #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kblok merged 5 commits into from
Feb 17, 2026
+6 −5
Merged

Fix ChromeHeadlessShell launch crash #3146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
868d8c4
Fix ChromeHeadlessShell launch crash with "Invalid browser" error
kblok Feb 16, 2026
c6df04a
Fix flaky ShouldThrowWhenEvaluationTriggersReload test
kblok Feb 17, 2026
52ad927
Merge branch 'master' into fix-chrome-headless-shell-launch-2967
kblok Feb 17, 2026
c864fe9
Fix build error: Assert.ThrowsAsync returns T directly in NUnit 4
kblok Feb 17, 2026
a6e71ec
Fix ChromeHeadlessShell download being skipped
kblok Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/PuppeteerSharp.Tests/EvaluationTests/PageEvaluateTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,8 @@ public void ShouldThrowWhenEvaluationTriggersReload()
}");
});

Assert.That(exception.Message, Does.Contain("Protocol error"));
Assert.That(exception.Message, Does.Contain("Execution context was destroyed")
.Or.Contain("no such frame"));
}

[Test, PuppeteerTest("evaluation.spec", "Evaluation specs Page.evaluate", "should work right after framenavigated")]
Expand Down
8 changes: 4 additions & 4 deletions lib/PuppeteerSharp/BrowserFetcher.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,11 +252,11 @@ private async Task<InstalledBrowser> DownloadAsync(SupportedBrowser browser, str

var outputPath = cache.GetInstallationDir(browser, Platform, buildId);

if (new FileInfo(GetExecutablePath(buildId)).Exists)
var installedBrowserCandidate = new InstalledBrowser(cache, browser, buildId, Platform);
if (new FileInfo(installedBrowserCandidate.GetExecutablePath()).Exists)
{
var existingBrowser = new InstalledBrowser(cache, browser, buildId, Platform);
existingBrowser.PermissionsFixed = RunSetup(existingBrowser);
return existingBrowser;
installedBrowserCandidate.PermissionsFixed = RunSetup(installedBrowserCandidate);
return installedBrowserCandidate;
}

try
Expand Down
Loading