Merged
Conversation
Add SupportedBrowser.ChromeHeadlessShell to the Process switch in Launcher so it uses ChromeLauncher, matching the buildId switch above. Fixes #2967 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add missing async/await and align error message assertion with upstream Puppeteer (expect "Execution context was destroyed" or "no such frame" instead of "Protocol error"). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
NUnit 4's Assert.ThrowsAsync<T> returns T, not Task<T>, so it cannot be awaited. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The existence check in DownloadAsync used the instance's Browser property (Chrome) instead of the passed browser parameter (ChromeHeadlessShell), so it incorrectly thought ChromeHeadlessShell was already downloaded when Chrome existed. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SupportedBrowser.ChromeHeadlessShellto the browser switch inLauncher.cs, which was causing an "Invalid browser" exception when launching chrome-headless-shellShouldThrowWhenEvaluationTriggersReloadtestFixes #2967
Test plan
🤖 Generated with Claude Code