Skip to content

remove api endpoint to create, update, and destroy devlogs#1056

Merged
cskartikey merged 1 commit intomainfrom
remove_endpoint
Jan 25, 2026
Merged

remove api endpoint to create, update, and destroy devlogs#1056
cskartikey merged 1 commit intomainfrom
remove_endpoint

Conversation

@cskartikey
Copy link
Member

I don't feel comfortable with a route that could do all of these especially in its current implementation

@cskartikey
Copy link
Member Author

cc: @3kh0 & @Lordseriouspig

@cskartikey cskartikey added this pull request to the merge queue Jan 25, 2026
Merged via the queue into main with commit d4e98ad Jan 25, 2026
5 checks passed
@Lordseriouspig
Copy link
Member

Respectfully I don't see a reason to remove them. If there was an issue with it, I'd implore you to let me know or fix it, but right now, I don't see anything wrong with it.

@Lordseriouspig
Copy link
Member

This PR also inadvertently removed the GET (index and list) routes for a project's devlogs too.

Lordseriouspig added a commit to Lordseriouspig/flavorcli that referenced this pull request Jan 25, 2026
Removed because merged pr hackclub/flavortown#1056 removes the corrosponding routes from the API.

BREAKING CHANGE: Removes commands and functionality related to devlog creation, updating, and deletion.
Lordseriouspig added a commit to Lordseriouspig/flavorcli that referenced this pull request Jan 25, 2026
Removed because merged PR hackclub/flavortown#1056 removes project devlog routes which these used

BREAKING CHANGE: Removes some options and functionality from devlog commands
Lordseriouspig added a commit to Lordseriouspig/flavorcli that referenced this pull request Jan 25, 2026
Removed because merged PR hackclub/flavortown#1056 removes the project-specific devlog endpoints that this relys on.

BREAKING CHANGE: The `project_id` parameter was removed from devlog list.
@Lordseriouspig
Copy link
Member

Respectfully I don't see a reason to remove them. If there was an issue with it, I'd implore you to let me know or fix it, but right now, I don't see anything wrong with it.

@cskartikey ?

@Joko-26
Copy link

Joko-26 commented Feb 2, 2026

With this change, it’s no longer possible to build a full Flavortown extension with all intended features.
I also started working on a VS Code extension, only to discover after ~6 hours that a critical endpoint had been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments