Add information about geotop stratigraphic units#361
Merged
rubencalje merged 4 commits intodevfrom Aug 27, 2024
Merged
Conversation
dbrakenhoff
approved these changes
Jul 10, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the files REF_GTP_LITHO_CLASS.xlsx and REF_GTP_STR_UNIT.xlsx, which are copied from the GeoTOP-zip-file (version 1.6) downloaded from DINOloket. This PR adds a method (
_save_excel_files_as_csv, which is never to be called directly by the user) to transform these xlsx-files into csv-files, which are better tracked using version-control, so we can monitor changes in future geotop-versions.REF_GTP_STR_UNIT.csvcontains all the lastest stratigraphic units, of which we misinterpreted some (1095) in the list we used to use (geo_eenheden.csv).One major benefit of this approach is that
REF_GTP_STR_UNIT.csvcontains a columnSEQ_NR, which gives information about the sequence in which layers occur. We can use thisSEQ_NRwhen we transform the geotop data into a layer model, usingnlmod.read.geotop.to_model_layers().