Memoryview patch #18

ghost · 2020-08-23T12:51:59Z

Initial commit.

Declared & defined memory_iter()
Defined memoryiterobject and a (basic) PyMemoryIter_Type
Added the aforementioned memory_iter() to PyMemoryView_Type.tp_iter

... when an unknown option is passed. TypeError was being raised because a 2to3 fix was missing. Co-authored-by: Terry Jan Reedy <[email protected]>

The error is exposed on non-UTF-8 locales.

…ation (pythonGH-19969) (We censor the heck out of actions and some other stuff using a custom "highlighter".) Co-authored-by: Guido van Rossum <[email protected]>

@lysnikolaou

) Automerge-Triggered-By: @lysnikolaou

@gvanrossum

Co-Authored-By: Rishi <[email protected]> Automerge-Triggered-By: @gvanrossum

This will improve the debug experience if something fails in the produced AST. Previously, errors in the produced AST can be felt much later like in the garbage collector or the compiler, making debugging them much more difficult.

Co-Authored-By: Baptiste Darthenay <[email protected]>

…ythonGH-21653)

Prevent installation on Windows 8 and earlier. Download UCRT on demand when required (non-updated Windows 8.1 only) Add reference to py launcher to post-install message

…H-21465)

…onGH-21665)

…thonGH-21569) This consolidates the handling of my_fgets return values, so that interrupts are always handled, even if they come after EOF. I believe PyOS_StdioReadline is still buggy in that I/O errors will not result in a proper Python exception being set. However, that is a separate issue.

@brettcannon

) Automerge-Triggered-By: @brettcannon

…honGH-21517) * Move 'peephole' optimizations into compile.c and perform them directly on the CFG.

…H-21694)

…nGH-21695)

…ions and ordering (python#21574) Also added PEP 585 deprecation notes.

…GH-21707)

Co-authored-by: Ankit Chandawala <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>

@xvxvxvxvxv

) My mentee @xvxvxvxvxv noticed that iterating over array.array is slightly faster than iterating over bytes. Looking at the source I observed that arrayiter_next() calls `getitem(ao, it->index++)` wheras striter_next() uses the idiom (paraphrased) item = PyLong_FromLong(seq->ob_sval[it->it_index]); if (item != NULL) ++it->it_next; return item; I'm not 100% sure but I think that the second version has fewer opportunity for the CPU to overlap the `index++` operation with the rest of the code (which in both cases involves a call). So here I am optimistically incrementing the index -- if the PyLong_FromLong() call fails, this will leave the iterator pointing at the next byte, but honestly I doubt that anyone would seriously consider resuming use of the iterator after that kind of failure (it would have to be a MemoryError). And the author of arrayiter_next() made the same consideration (or never ever gave it a thought :-). With this, a loop like for _ in b: pass is now slightly *faster* than the same thing over an equivalent array, rather than slightly *slower* (in both cases a few percent).

…21449)

…21451)

…21448)

…thonGH-21718) regrtest_unraisable_hook() temporarily replaces sys.stderr with sys.__stderr__ to help to display errors when a test captures stderr.

incr cannot be larger than INT_MAX: downcast to int explicitly.

On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b'').

Fix grammar in BaseTransport.close docstring. https://bugs.python.org/issue41572 Signed-off-by: Cleber Rosa <[email protected]>

gvanrossum · 2020-08-23T17:30:25Z

There's something weird in the PR -- I think my master was way behind your master (that's my fault) and you ended up pushing 114 commits by others to the PR. I'm not quite sure how to fix it, even though I have now updated my master. I'll just ignore it, I can see your change just fine.

gvanrossum

Have you run your code yet? I did, and I discovered the missing tp_dealloc that way (well, I had to jump in the debugger for a bit).

BTW have you ran ./configure --with-pydebug? That's important in this phase, the resulting interpreter has many self-checks enabled that will help you debugging your code.

Good luck!

gvanrossum · 2020-08-23T17:31:10Z

Objects/memoryobject.c

 };


+


I think three blank lines is too much. :)

Absolutely! Missed that one.

Objects/memoryobject.c

ghost · 2020-08-23T19:56:01Z

BTW have you ran ./configure --with-pydebug?

I forgot. Will do it next time before pushing the code.

Objects/memoryobject.c

gvanrossum

Here are a few suggestions for fixing the coding style per PEP 7. (Read it!)

Objects/memoryobject.c

ghost · 2020-08-31T19:41:38Z

Thank you, Guido, for all the suggestions. I will go through PEP7 in detail.

Co-authored-by: Guido van Rossum <[email protected]>

gvanrossum · 2020-09-01T00:42:15Z

Diogo, maybe this would be a good time to try if you can get rid of the 100+ extra commits that somehow got included in this commit. You may have to do some searching about git on stackoverflow.com.

Also, this somehow did register:

Can you come up with more creative commit titles than " Update Objects/memoryobject.c"? If you're committing suggestions from the GitHub UI, you can edit it there. Also, if you're viewing the suggestions from the "Files changed" tab you can use the "Add to batch" option to make a single commit with all the suggestions.

(Don't worry about what you've already done, everybody has to learn these. :-)

ghost · 2020-09-01T08:29:38Z

I will look for a solution to get rid of the extra commits, although perhaps a cleaner solution would be for both of us to sync with the official python repo and then I would just push a new branch with all the changes we made so far in one commit. What do you think about this option?

Also, I still want to remove the now double check that unnecessarily happens in memory_item (since we now do the check for dimensions in memoryiter_next).

(Don't worry about what you've already done, everybody has to learn these. :-)

Thank you. Always learning.

gvanrossum · 2020-09-01T14:45:42Z

I synced master fairly recently. (After you pushed this PR though.) If you can pull master from my repo, make a branch off that, and push that branch back and make it into a PR, that should work.

gvanrossum · 2020-09-03T23:40:36Z

Closing in favor of #19.

linchiwei123 and others added 30 commits July 26, 2020 20:33

Fix atexitmodule doc (pythonGH-21456)

52bf470

bpo-41384: Raise TclError in tkinter.OptionMenu (pythonGH-21601)

f1d40f9

... when an unknown option is passed. TypeError was being raised because a 2to3 fix was missing. Co-authored-by: Terry Jan Reedy <[email protected]>

bpo-41340: Removed fallback implementation for strdup (pythonGH-21634)

5798f78

bpo-31904: Fix test_ftplib failures for VxWorks RTOS (pythonGH-19447)

855e688

bpo-41401: Fix test_fspath_support in test_io. (pythonGH-21640)

67987ac

The error is exposed on non-UTF-8 locales.

bpo-40939: Use the new grammar for the grammar specification document…

72cabb2

…ation (pythonGH-19969) (We censor the heck out of actions and some other stuff using a custom "highlighter".) Co-authored-by: Guido van Rossum <[email protected]>

bpo-40939: Remove even more references to the old parser (pythonGH-21642

b3fbff7

) Automerge-Triggered-By: @lysnikolaou

bpo-41045: Document debug feature of f-strings ('=') (pythonGH-21509)

13efaec

Co-Authored-By: Rishi <[email protected]> Automerge-Triggered-By: @gvanrossum

bpo-35328: Set VIRTUAL_ENV_PROMPT at venv activation (pythonGH-21587)

c82dda1

Co-Authored-By: Baptiste Darthenay <[email protected]>

bpo-41328: Replace mention of Hudson CI with Travis CI and AppVeyor (p…

5e38267

…ythonGH-21653)

bpo-41412 and bpo-40948: Windows installer updates (pythonGH-21656)

37a06cb

Prevent installation on Windows 8 and earlier. Download UCRT on demand when required (non-updated Windows 8.1 only) Add reference to py launcher to post-install message

Fix List_Append description, list is extracted at TOS1[-i] (pythonG…

34cd3e9

…H-21465)

Remove incorrect mention of method.__class__ in descriptor docs (pyth…

f6a16e8

…onGH-21665)

bpo-41426 Fix grammar in curses.getmouse() documentation (pythonGH-21677

ba18c0b

) Automerge-Triggered-By: @brettcannon

bpo-41323: Perform 'peephole' optimizations directly on the CFG. (pyt…

6e8128f

…honGH-21517) * Move 'peephole' optimizations into compile.c and perform them directly on the CFG.

bpo-40360: Handle PendingDeprecationWarning in test_lib2to3. (pythonG…

cadda52

…H-21694)

bpo-41421: Algebraic simplification for random.paretovariate() (pytho…

5c32709

…nGH-21695)

random module: Convert a "while 1" to "while True (pythonGH-21700)

6a613f9

bpo-40979: refactored typing.rst; (mostly) same content, new sub-sect…

ab72fde

…ions and ordering (python#21574) Also added PEP 585 deprecation notes.

bpo-41424: Remove extra words in Tkinter-Packer documentation (python…

ecaf949

…GH-21707)

bpo-41425: Make tkinter doc example runnable (pythonGH-21706)

c36dbac

Co-authored-by: Ankit Chandawala <[email protected]> Co-authored-by: Terry Jan Reedy <[email protected]>

bpo-40275: Use new test.support helper submodules in tests (pythonGH-…

a7f5d93

…21449)

bpo-40275: Use new test.support helper submodules in tests (pythonGH-…

bb0424b

…21451)

bpo-40275: Use new test.support helper submodules in tests (pythonGH-…

4660597

…21448)

bpo-38912: regrtest logs unraisable exception into sys.__stderr__ (py…

701b638

…thonGH-21718) regrtest_unraisable_hook() temporarily replaces sys.stderr with sys.__stderr__ to help to display errors when a test captures stderr.

bpo-38156: Fix compiler warning in PyOS_StdioReadline() (pythonGH-21721)

bde48fd

incr cannot be larger than INT_MAX: downcast to int explicitly.

bpo-41467: Fix asyncio recv_into() on Windows (pythonGH-21720)

602a971

On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b'').

clebergnu and others added 6 commits August 20, 2020 18:10

bpo-41572: Fix grammar in BaseTransport.close docstring (pythonGH-21914)

1afb42c

Fix grammar in BaseTransport.close docstring. https://bugs.python.org/issue41572 Signed-off-by: Cleber Rosa <[email protected]>

Doc: add a missing period (pythonGH-21819)

12695f4

Update references from travis-ci.org to travis-ci.com (pythonGH-21919)

d2b0ce6

bpo-41573: Update release versions in General FAQ (pythonGH-21915)

7173fc8

Document vars behavior when __dict__ is missing (python#21466)

802726a

memoryview_patch initial commit

fc7b41f

ghost requested a review from gvanrossum as a code owner August 23, 2020 12:51

gvanrossum reviewed Aug 23, 2020

View reviewed changes

gvanrossum marked this pull request as draft August 26, 2020 20:54

Diogo Flores added 3 commits August 27, 2020 10:03

New Macro PyMemoryView_GET_SIZE(op)

585fe5a

WIP memoryiter_next

cc45e07

Fix formatting

6e3a66e

gvanrossum reviewed Aug 27, 2020

View reviewed changes

Objects/memoryobject.c Outdated Show resolved Hide resolved

WIP memoryiter_next - continuation

db8123d

gvanrossum reviewed Aug 28, 2020

View reviewed changes

Objects/memoryobject.c Show resolved Hide resolved

Diogo Flores added 2 commits August 30, 2020 20:05

bugfix - improper macro

359d828

Remove unused macro

35ff087

gvanrossum reviewed Aug 31, 2020

View reviewed changes

xvxvxvxvxv and others added 4 commits August 31, 2020 20:55

Update Objects/memoryobject.c

1b5d6ee

Co-authored-by: Guido van Rossum <[email protected]>

Update Objects/memoryobject.c

f81a286

Co-authored-by: Guido van Rossum <[email protected]>

Update Objects/memoryobject.c

57b76b3

Co-authored-by: Guido van Rossum <[email protected]>

Error-handling + formatting

4386011

gvanrossum closed this Sep 3, 2020

Memoryview patch #18

Memoryview patch #18

Uh oh!

Conversation

ghost commented Aug 23, 2020

Uh oh!

gvanrossum commented Aug 23, 2020

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

gvanrossum Aug 23, 2020

Choose a reason for hiding this comment

Uh oh!

ghost Aug 23, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost commented Aug 23, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Aug 31, 2020

Uh oh!

gvanrossum commented Sep 1, 2020

Uh oh!

ghost commented Sep 1, 2020 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gvanrossum commented Sep 1, 2020

Uh oh!

gvanrossum commented Sep 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

ghost commented Aug 23, 2020 •

edited by ghost

Loading

ghost commented Sep 1, 2020 •

edited by ghost

Loading